lwIP - A Lightweight TCP/IP stack - Bugs: bug #54062, Inconsequent null pointer checks
You are not allowed to post comments on this tracker with your current authentication level.
bug #54062: Inconsequent null pointer checks
Submitter: | Matthias Hofmann <mhofmann> | ||
Submitted: | Tue 05 Jun 2018 09:48:27 AM UTC | ||
Category: | None | Severity: | 3 - Normal |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | 2.1.0 |
lwIP version: | 2.0.3 |
Jump to the original submission
Thu 14 Jun 2018 02:21:15 PM UTC, comment #20: |
Simon Goldschmidt <goldsimon> |
Thu 14 Jun 2018 11:44:18 AM UTC, comment #19: OK, sorry. I'll take a look again. |
Simon Goldschmidt <goldsimon> |
Thu 14 Jun 2018 11:43:09 AM UTC, comment #18: It looks like some got lost during changing the patch for master and some were filtered by you.
|
Matthias Hofmann <mhofmann> |
Wed 13 Jun 2018 12:02:06 PM UTC, comment #17: In comment #6 you wrote:
|
Simon Goldschmidt <goldsimon> |
Wed 13 Jun 2018 08:01:18 AM UTC, comment #16: There are multiple functions that dereference pointer arguments without checking them:
|
Matthias Hofmann <mhofmann> |
Tue 12 Jun 2018 08:26:13 AM UTC, comment #15: Pushed, thanks for the patch. I still had to clean up multiple things, so you might want to check if you're OK with the current status.
|
Simon Goldschmidt <goldsimon> |
Mon 11 Jun 2018 07:52:21 AM UTC, comment #14: There's no ongoing development on the STABLE-2_0_0 branch, so no separate patches are needed. Just one for master. |
Simon Goldschmidt <goldsimon> |
Mon 11 Jun 2018 07:50:18 AM UTC, comment #13: The differences between master and STABLE-2_0_0 are a little bit bigger. So you need different patches for master and stable branch:
|
Matthias Hofmann <mhofmann> |
Fri 08 Jun 2018 09:11:11 PM UTC, comment #12: Please rebase to git master, applying the patch fails. |
Simon Goldschmidt <goldsimon> |
Fri 08 Jun 2018 07:45:34 PM UTC, comment #11: Ok, LWIP_ERROR and LWIP_ASSERT are flexible enough to be replaced by space-saving version on demand. So, error messages prefixed by function name are better. |
Jan Breuer <jan_breuer> |
Fri 08 Jun 2018 01:53:27 PM UTC, comment #10: The reworked patch with long error messages is done. |
Matthias Hofmann <mhofmann> |
Fri 08 Jun 2018 01:06:05 PM UTC, comment #9: As a user I know I would definitely prefer see and debug "udp_input: invalid pcb" instead of "invalid pcb".
|
Jason White <wrc_jasonw> |
Fri 08 Jun 2018 09:06:35 AM UTC, comment #8: For the error messages I have oriented towards api_lib.c style.
|
Matthias Hofmann <mhofmann> |
Thu 07 Jun 2018 01:40:38 PM UTC, comment #7: Some notes to your patch
|
Jan Breuer <jan_breuer> |
Thu 07 Jun 2018 01:10:24 PM UTC, comment #6: With the attached patch null pointer usage can be detected reliable. |
Matthias Hofmann <mhofmann> |
Thu 07 Jun 2018 05:29:52 AM UTC, comment #5: I'm working on a patch according to your advice. When it is done we can close the bug and additional rework can be provided as patches.
|
Matthias Hofmann <mhofmann> |
Wed 06 Jun 2018 07:26:12 PM UTC, comment #4: Well, you can't say it like that. You have to differentiate:
|
Simon Goldschmidt <goldsimon> |
Wed 06 Jun 2018 10:00:29 AM UTC, comment #3: So LWIP_ERROR shall be used for null pointer checks? As I see it is already used for the higher API layers netconn and socket.
|
Matthias Hofmann <mhofmann> |
Wed 06 Jun 2018 08:00:14 AM UTC, comment #2: We've had a lot of discussion about LWIP_ASSERT, although that is some years ago. The question is whether you have it enabled at runtime or not and if you still check null pointers when LWIP_ASSERT is disabled or not...
|
Simon Goldschmidt <goldsimon> |
Tue 05 Jun 2018 04:24:59 PM UTC, comment #1: As a user I would love to see more LWIP_ASSERT coverage.
|
Jason White <wrc_jasonw> |
Tue 05 Jun 2018 09:48:27 AM UTC, original submission:
Hey,
|
Matthias Hofmann <mhofmann> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 13 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-06-14 | goldsimon | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2018-06-14 | goldsimon | Item Group | None | Change Request | |
Status | Fixed | In Progress | |||
Open/Closed | Closed | Open | |||
Planned Release | None | 2.1.0 | |||
2018-06-14 | mhofmann | Attached File | - | Added 0004-Add-missing-null-checks.patch, #44367 | |
2018-06-12 | goldsimon | Status | None | Fixed | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2018-06-11 | mhofmann | Attached File | - | Added 0003-Add-null-pointer-checks-for-TCP-UDP-and-netif_for-master.patch, #44357 | |
2018-06-08 | mhofmann | Attached File | - | Added 0002-Add-null-pointer-checks-for-TCP-UDP-and-netif.patch, #44332 | |
2018-06-07 | mhofmann | Attached File | - | Added 0001-Add-null-pointer-checks-for-TCP-UDP-and-netif.patch, #44321 |
Powered by Savane 3.13-caa5.
Corresponding source code
Pushed, thanks for the patch.