buglwIP - A Lightweight TCP/IP stack - Bugs: bug #54194, tcp_out.c, 333: extra check

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #54194: tcp_out.c, 333: extra check

Submitter:  Andrey Vinogradov <andreyvinogradov>
Submitted:  Wed 27 Jun 2018 12:35:51 PM UTC
   
 
Category:  TCP Severity:  3 - Normal
Item Group:  Compiler Warning Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  2.1.0
lwIP version:  git head

Wed 27 Jun 2018 06:44:45 PM UTC, comment #3: 

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Wed 27 Jun 2018 12:39:16 PM UTC, comment #2: 

659:

if ((queuelen > TCP_SND_QUEUELEN) || (queuelen > TCP_SNDQUEUELEN_OVERFLOW)) {
...
}

same goes here

Andrey Vinogradov <andreyvinogradov>
Wed 27 Jun 2018 12:37:18 PM UTC, comment #1: 

oups, can't fix header(

Andrey Vinogradov <andreyvinogradov>
Wed 27 Jun 2018 12:35:51 PM UTC, original submission:  


  if ((pcb->snd_queuelen >= TCP_SND_QUEUELEN) || (pcb->snd_queuelen > TCP_SNDQUEUELEN_OVERFLOW)) {
...
}

Second condition not needed because TCP_SND_QUEUELEN < TCP_SNDQUEUELEN_OVERFLOW

Andrey Vinogradov <andreyvinogradov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Updated the item)
  • -email is unavailable- added by andreyvinogradov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-06-27 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
        Planned ReleaseNone 2.1.0
    2018-06-27 goldsimon Summary&lt;h3&gt;&lt;font color=&quot;green&quot;&gt;tcp_out.c, 333: extra check&lt;/font&gt;&lt;/h3&gt; tcp_out.c, 333: extra check

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code