buglwIP - A Lightweight TCP/IP stack - Bugs: bug #54195, ethernet.c, 178 & 195: extra...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #54195: ethernet.c, 178 & 195: extra condition

Submitter:  Andrey Vinogradov <andreyvinogradov>
Submitted:  Wed 27 Jun 2018 04:54:26 PM UTC
   
 
Category:  Network drivers Severity:  3 - Normal
Item Group:  Compiler Warning Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Wed 27 Jun 2018 06:52:10 PM UTC, comment #1: 

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Wed 27 Jun 2018 04:54:26 PM UTC, original submission:  

At line 91:
  if (p->len <= SIZEOF_ETH_HDR) {
    ...
    goto free_and_return;
  }

Next at line 178 & 195:
if ((p->len < next_hdr_offset) || pbuf_remove_header(p, next_hdr_offset)) {
...
    goto free_and_return;
}

So p->len checks twice

Andrey Vinogradov <andreyvinogradov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by andreyvinogradov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-06-27 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code