buglwIP - A Lightweight TCP/IP stack - Bugs: bug #56231, Include path issue with mbedtls...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #56231: Include path issue with mbedtls build integration

Submitted by:  Ashley Duncan <ashesman>
Submitted on:  Sun 28 Apr 2019 07:10:21 AM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Invalid
Privacy:  Public Assigned to:  Simon Goldschmidt <goldsimon>
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Thu 30 Jan 2020 10:47:06 PM UTC, comment #4: 

Ok, thanks for taking the effort with the mbedtls team. I'll close this one as invalid (since it was only with a git state of mbedtls, not a release).

Please reopen or drop a comment if we still need to react for lwIP.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 30 Jan 2020 10:43:26 PM UTC, comment #3: 

I believe this issue is resolved.  See https://github.com/ARMmbed/mbedtls/issues/2609.  In the next few days/weeks I will be having a go at including lwip and mbedtls as submodules in a new project so will see how it goes.

This issue could probably be closed.

Ashley Duncan <ashesman>
Thu 30 Jan 2020 10:19:09 PM UTC, comment #2: 

Any input on this with current cmake sources?

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Mon 29 Apr 2019 08:49:58 AM UTC, comment #1: 

Note that this issue is currently in the development branch of mbedtls only.  Master is OK.  I have submitted an issue on mbedtls with a fix.  However, if this fix is not applied and makes it to master next release, LwIP will no longer build with mbedtls.

Ashley Duncan <ashesman>
Sun 28 Apr 2019 07:10:21 AM UTC, original submission:  

When building lwip with mbedtls support, the mbedtls include path is incorrectly set.

To reproduce clone lwip and mbedtls into the same folder.  Enable mbedtls in lwip/contrib/example/example_app/lwipopts.h with #define LWIP_HAVE_MBEDTLS 1

This causes mbedtls to be added as a sub directory (CMakeCommon.cmake line 26)

When built from LwIP, CMAKE_SOURCE_DIR will always be the top level build dir .../lwip

mbedtls is built with .../lwip as the top level build folder

mbedtls/library/CMakeLists.txt line 153 sets the target include path to ${CMAKE_SOURCE_DIR}/include.  The resulting path is .../lwip/include (which is incorrect and doesn't exist) and should be .../mbedtls/include

Sorry I cannot provide a suggested solution as my cmake knowledge is limited.  It seems that mbedtls was not meant to be built from withing another project which is surprising.  A solution may be to change mbedtls to define its root dir and use paths relative to that.

Ashley Duncan <ashesman>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by ashesman (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-01-30 goldsimon StatusNone => Invalid
        Assigned toNone => goldsimon
        Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.5