lwIP - A Lightweight TCP/IP stack - Bugs: bug #37156, [ppp-new] missing <stdlib.h>...
You are not allowed to post comments on this tracker with your current authentication level.
bug #37156: [ppp-new] missing <stdlib.h> + namespace conflict with some libc about strlcpy() and strlcat() utils.c functions
Submitter: | hanhui <hanhui03> | ||
Submitted: | Tue 21 Aug 2012 11:26:55 AM UTC | ||
Category: | None | Severity: | 2 - Minor |
Item Group: | Compiler Warning | Status: | Fixed |
Privacy: | Public | Assigned to: | gradator |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | Other |
Jump to the original submission
Tue 21 Aug 2012 06:32:07 PM UTC, comment #7: |
Sylvain Rochet <gradator> |
Tue 21 Aug 2012 01:25:33 PM UTC, comment #6:
|
Simon Goldschmidt <goldsimon> |
Tue 21 Aug 2012 01:21:07 PM UTC, comment #5: Yup, you are right about strtol() / <stdlib.h>, it will be added to ppp_impl.h.
|
Sylvain Rochet <gradator> |
Tue 21 Aug 2012 01:15:58 PM UTC, comment #4: strlcpy() and strlcat() are actually copied straight from PPPd, which doesn't seem to have been ported to OpenBSD or FreeBSD recently, which can explain why the conflict stay unnoticed until now.
|
Sylvain Rochet <gradator> |
Tue 21 Aug 2012 01:06:39 PM UTC, comment #3: Sorry,
|
hanhui <hanhui03> |
Tue 21 Aug 2012 12:56:23 PM UTC, comment #2: Regarding 2: I'd suggest to either rename these functions or making compiling them conditionally (as hanhui suggests, which is probably the better idea since you don't link the function twice if you already have it from somewhere else). At least you couldn't compile ppp-new under *BSD like it is now, could you?
|
Simon Goldschmidt <goldsimon> |
Tue 21 Aug 2012 12:32:50 PM UTC, comment #1: 1: I don't see why it is necessary, chap_ms.c includes netif/ppp/ppp_impl.h which includes <string.h>, could you clarify about that ?
|
Sylvain Rochet <gradator> |
Tue 21 Aug 2012 11:26:55 AM UTC, original submission:
1: chap_ms.c MUST add #include <string.h>
|
hanhui <hanhui03> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2012-08-21 | gradator | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2012-08-21 | gradator | Status | Need Info | In Progress | |
Summary | [ppp-new] some suggest | [ppp-new] missing <stdlib.h> + namespace conflict with some libc about strlcpy() and strlcat() utils.c functions | |||
2012-08-21 | gradator | Severity | 3 - Normal | 2 - Minor | |
Status | None | Need Info | |||
Assigned to | None | gradator |
Powered by Savane 3.13-caa5.
Corresponding source code
All exported (not static) utils.c functions renamed.
<stdlib.h> added to ppp_impl.h
Both bugs are fixed in ppp-new.