bugSpamAssassin Milter Plugin - Bugs: bug #13396, Spamassassin 3.0.3 or 3.0.4 give...

 
 

bug #13396: Spamassassin 3.0.3 or 3.0.4 give NULL context in mlfi_close

Submitter:  None
Submitted:  Tue 14 Jun 2005 11:11:08 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 14 Aug 2014 04:03:28 AM UTC, comment #5: 

in cvs; resolving.

Todd Kover <kovert>
Group administrator
Sat 13 Aug 2005 03:26:22 PM UTC, comment #4: 

I believe this happens when you have other milters, and one of them tells sendmail not to accept the incoming message. Spamass-milter then gets confused by the unexpected _abort call.

Nigel Horne <nigelhorne>
Mon 11 Jul 2005 03:59:33 PM UTC, comment #3: 

The "NULL context" message is actually benign; it turns out in certain cases sendmail will call the milter's close function without first calling any other ones.  It doesn't make any sense to me, which is why I added the check in the first place :)  It's mentioned in the docs, though, so I have removed the message.  You can apply this patch:

Index: spamass-milter.cpp
===================================================================
RCS file: /cvsroot/spamass-milt/spamass-milt/spamass-milter.cpp,v
diff -u -p -r1.88 -r1.89
--- spamass-milter.cpp  7 Apr 2005 02:04:24 -0000       1.88
+++ spamass-milter.cpp  2 Jun 2005 18:30:25 -0000       1.89
@@ -1246,11 +1246,8 @@ mlfi_close(SMFICTX* ctx)
  
   sctx = (struct context*)smfi_getpriv(ctx);
   if (sctx == NULL)
-  {
-    /* the context should have been set in mlfi_connect */
-       debug(D_ALWAYS, "NULL context in mlfi_close! Should not happen!");
     return SMFIS_ACCEPT;
-  }
+
   if (sctx->helo)
        free(sctx->helo);
   free(sctx);

Dan Nelson <dnelson>
Group administrator
Mon 11 Jul 2005 11:13:06 AM UTC, comment #2: 

Tried that, but it didn't solve anything.

The bug is totally random, looks like it happens when some kind of "e-mail" arrives, which breaks down spamass-milter :(

I forced clamav updates to once a day to avoid this, and it still happens frequently.

Marc Cluet <lynxman>
Wed 15 Jun 2005 06:22:15 AM UTC, comment #1: 

I've had the same problem with milters, when I was using spamass-milter and clamav-milter. Problem was rather with clamav which impact to spamass and was making "NULL context in mlfi_close! Should not happen! " errors. Aftre I've added
"OnUpdateExecute /etc/rc.d/init.d/clamav-milter restart" in /etc/freshclam.conf I didn't see this message anymore.

Mark <mpedziw>
Tue 14 Jun 2005 11:11:08 AM UTC, original submission:  

Hello
Running: Fedora Core 1
Kernel: 2.4.22-4.legacy
Sendmail: 8.13.5
spamass-milter: 0.3.0
Spamassasin versions tested: 3.0.2, 3.0.3, 3.0.4

Under moderate load spamass-milter fails with the following error message:
Jun 14 11:56:11 xxxx spamass-milter[16469]: NULL context in mlfi_close! Should not happen!
Jun 14 11:56:11 xxxx sendmail[28752]: j5E9uBx3028752: Milter: connect: host=xxxx, addr=xxx.xxx.xxx.xxx, temp failing commands

Versions that fail: 3.0.3, 3.0.4
Version working: 3.0.2

Failure rate: ALWAYS
Estimated failure time: 24-48 hours under moderate load

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by kovert (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-08-14 kovert StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code