lwIP - A Lightweight TCP/IP stack - Patches: patch #10086, mqtt.c : Remove useless...
You are not allowed to post comments on this tracker with your current authentication level.
patch #10086: mqtt.c : Remove useless LWIP_ASSERT_CORE_LOCKED()
Submitter: | Jonathan D <jona> | ||
Submitted: | Wed 07 Jul 2021 08:54:04 AM UTC | ||
Category: | apps | Priority: | 5 - Normal |
Status: | Wont Do | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | None |
Thu 12 Oct 2023 06:37:17 PM UTC, comment #1: |
Simon Goldschmidt <goldsimon> |
Wed 07 Jul 2021 08:54:04 AM UTC, original submission:
In mqtt.c, several LWIP_ASSERT_CORE_LOCKED are irrelevant. The most obvious is in mqtt_client_new which just does a calloc.
|
Jonathan D <jona> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2023-10-12 | goldsimon | Status | None | Wont Do | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2021-07-07 | jona | Attached File | - | Added 0001-mqtt.c-Remove-useless-LWIP_ASSERT_CORE_LOCKED.patch, #51657 |
Powered by Savane 3.13-3230.
Corresponding source code
The assert might be invalid in the current code, but the asserts define a "contract" to the application. And since we could, in the future, change 'mqtt_client_new()' to call into the core stack, the assertion is valid here (even if not required right now).
That prevents the need to change applications in the future: every "public" (exported) function of the mqtt client asserts that it is called correctly.
And yes, you need to use (UN)LOCK_TCPIP_CORE appropriately.