patchlwIP - A Lightweight TCP/IP stack - Patches: patch #10086, mqtt.c : Remove useless...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #10086: mqtt.c : Remove useless LWIP_ASSERT_CORE_LOCKED()

Submitted by:  Jonathan D <jona>
Submitted on:  Wed 07 Jul 2021 08:54:04 AM UTC
 
Category:  apps Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
Planned Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Wed 07 Jul 2021 08:54:04 AM UTC, original submission:  

In mqtt.c, several LWIP_ASSERT_CORE_LOCKED are irrelevant. The most obvious is in mqtt_client_new which just does a calloc.
I also found that LWIP_ASSERT_CORE_LOCKED in mqtt_client_is_connected and mqtt_set_inpub_callback are useless but they are not included in the patch.

As a sidenote, I have a separate thread to manage MQTT, does this means that each call to function with LWIP_ASSERT_CORE_LOCKED must be surrounded by (UN)LOCK_TCPIP_CORE ?

Jonathan D <jona>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jona (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-07-07 jona Attached File- => Added 0001-mqtt.c-Remove-useless-LWIP_ASSERT_CORE_LOCKED.patch, #51657

    Back to the top


    Powered by Savane 3.9