lwIP - A Lightweight TCP/IP stack - Patches: patch #5777, Avoid OS functions'names conflit...
You are not allowed to post comments on this tracker with your current authentication level.
patch #5777: Avoid OS functions'names conflit with some sockets.h names...
Submitter: | Frédéric Bernon <fbernon> | ||
Submitted: | Sun 04 Mar 2007 01:32:39 PM UTC | ||
Category: | None | Priority: | 3 - Low |
Status: | Done | Privacy: | Public |
Assigned to: | fbernon | Open/Closed: | Closed |
Planned Release: | None |
Mon 05 Mar 2007 10:48:37 AM UTC, comment #5: |
Frédéric Bernon <fbernon> |
Mon 05 Mar 2007 10:19:37 AM UTC, comment #4: Last think before do it, some includes are always need in sockets.h to use some setsockopts.h (like TCP_NODELAY and TCP_KEEPALIVE):
|
Frédéric Bernon <fbernon> |
Mon 05 Mar 2007 09:54:03 AM UTC, comment #3: Sure, So, I will integrate it in CVS, with comments.
|
Frédéric Bernon <fbernon> |
Mon 05 Mar 2007 09:18:02 AM UTC, comment #2: Second Simon's comments, particularly about sticking to the same "#if" style as the rest of the configuration options. |
Kieran Mansley <kieranm> |
Mon 05 Mar 2007 07:44:28 AM UTC, comment #1: I think that's a good change, but I would stick to the other #if's (removing the defined(LWIP_POSIX_SOCKETS_IO_NAMES), you'd define it in opt.h, anyway, either to 0 or != 0. => #if LWIP_POSIX_SOCKETS_IO_NAMES should be enough).
|
Simon Goldschmidt <goldsimon> |
Sun 04 Mar 2007 01:32:39 PM UTC, original submission:
In the forum's thread "LWIP_COMPAT_SOCKETS in sockets.h" (September 2006). I suggest to add a new define to avoid to have function names's conflits with some sockets.h functions, and some operating system's IO function (read, write and close).
|
Frédéric Bernon <fbernon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-03-05 | fbernon | Status | In Progress | Done | |
Open/Closed | Open | Closed | |||
2007-03-05 | fbernon | Attached File | - | Added opt.h.patch, #12112 | |
2007-03-05 | kieranm | Priority | 5 - Normal | 3 - Low |
Powered by Savane 3.13-caa5.
Corresponding source code
See the patch file join to this item. Is it ok for you to integrate?
Note, there is also the SO_REUSE to avoid compiler warning (no change from previous), and the ETHARP_TRUST_IP_MAC (which is need for some "futur" patchs about the ARP table.
(file #12112)