lwIP - A Lightweight TCP/IP stack - Patches: patch #5778, Warning in opt.h about SO_REUSE
You are not allowed to post comments on this tracker with your current authentication level.
patch #5778: Warning in opt.h about SO_REUSE
Submitter: | Frédéric Bernon <fbernon> | ||
Submitted: | Sun 04 Mar 2007 01:36:04 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | fbernon | Open/Closed: | Closed |
Planned Release: | None |
Mon 05 Mar 2007 09:23:19 AM UTC, comment #3: |
Frédéric Bernon <fbernon> |
Mon 05 Mar 2007 09:20:19 AM UTC, comment #2: If they're upgrading they'll get a compile error when they compile lwIP.
|
Kieran Mansley <kieranm> |
Mon 05 Mar 2007 07:15:44 AM UTC, comment #1: 1. If someone relies on the SO_REUSE funcionality and upgrades from an older version, he won't get a warning but instead his program will simply fail.
|
Simon Goldschmidt <goldsimon> |
Sun 04 Mar 2007 01:36:04 PM UTC, original submission:
The current SO_REUSE define in opt.h give a warning. A simple patch will be to define it like this :
|
Frédéric Bernon <fbernon> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 2 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-03-05 | fbernon | Status | In Progress | Done | |
Open/Closed | Open | Closed |
Powered by Savane 3.13-02a9.
Corresponding source code
1. In fact, this patch is only to remove warning at build time. But, if someone upgrades from an older version, there is two possibilities :
- he never define SO_REUSE, in this case, no warning at build time, and if he execute his program, setsockopt will give a ENOPROTOOPT runtime error.
- he already set SO_REUSE to 1 in his lwipopts.h, in this case, he will get the error message "SO_REUSE currently unavailable..." at build time. He just have to remove SO_REUSE in his lwipiopts.h
2. I hope perhaps "someone" will fix the code (like you with APR_QUEUING). But I even if the lwip current design is to tell "one thread at one netconn (and thus socket) at a time", you can use SO_REUSEADDR to allow two differents sockets to receive the same broadcast or multicast UDP "streams".
So, that's why I have propose this patch...