patchlwIP - A Lightweight TCP/IP stack - Patches: patch #5795, debug.h name's conflicts

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5795: debug.h name's conflicts

Submitter:  Frédéric Bernon <fbernon>
Submitted:  Sun 11 Mar 2007 04:12:55 PM UTC
   
 
Category:  None Priority:  3 - Low
Status:  Done Privacy:  Public
Assigned to:  fbernon Open/Closed:  Closed
Planned Release:  None

Jump to the original submission

Wed 04 Apr 2007 07:33:32 AM UTC, comment #7: 

I have update the contrib module with new names. I will commit tomorrow or this evening if no objections...

Patch file is attached...


(file #12393)

Frédéric Bernon <fbernon>
Group Member
Fri 30 Mar 2007 09:22:56 AM UTC, comment #6: 

Up to you - a lot of the ports don't have active maintainers and so will soon be archived.

Kieran Mansley <kieranm>
Group Member
Fri 30 Mar 2007 08:52:28 AM UTC, comment #5: 

I don't know if I have to update contrib modules, or if I have to let port maintainers do. Kieran, I can change them if you want...

Frédéric Bernon <fbernon>
Group Member
Fri 30 Mar 2007 07:49:56 AM UTC, comment #4: 

That's great, thanks.  Go ahead.

Kieran Mansley <kieranm>
Group Member
Wed 28 Mar 2007 06:47:23 PM UTC, comment #3: 

Ok, patch file is attach. Kieran, can you confirm I can commit ?

(file #12323)

Frédéric Bernon <fbernon>
Group Member
Mon 12 Mar 2007 08:44:28 AM UTC, comment #2: 

Agreed.

Kieran Mansley <kieranm>
Group Member
Sun 11 Mar 2007 05:16:46 PM UTC, comment #1: 

I think adding LWIP_ would be good, even though I don't have this problem.

Simon Goldschmidt <goldsimon>
Group administrator
Sun 11 Mar 2007 04:12:55 PM UTC, original submission:  

I don't know if I'm alone with this kind of problem, but some defines in debug.h, with too generic names, like DBG_STATE or DBG_TRACE have same names that my platform's debug tools, but, of course, with different values. Problem is that opt.h, which is indirectly in the application scope, also include debug.h (but, that, it's normal).

My workaround is to include a #undef before each name with problem.

But, if some others developers got the same problem, I propose to prefix these defines with LWIP_ (so, we will got LWIP_DBG_STATE, LWIP_DBG_TRACE, etc...) in debug.h, and in all others files.

Frédéric Bernon <fbernon>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #12393:  Contrib.patch added by fbernon (17KiB - text/x-patch)
file #12323:  debug.patch added by fbernon (55KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by kieranm (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by fbernon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-04-04 fbernon Attached File- Added Contrib.patch, #12393
    2007-03-30 fbernon StatusNone Done
        Open/ClosedOpen Closed
    2007-03-28 fbernon Attached File- Added debug.patch, #12323

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code