patchlwIP - A Lightweight TCP/IP stack - Patches: patch #5904, etharp.h: define ETH_PAD_SIZE...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5904: etharp.h: define ETH_PAD_SIZE after including opt.h

Submitter:  Simon Goldschmidt <goldsimon>
Submitted:  Sun 29 Apr 2007 05:03:36 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Mon 30 Apr 2007 11:45:45 AM UTC, comment #2: 

Ah, that's where I read it!

OK, checking this in and closing it as done since I think this is rather obvious.

Simon Goldschmidt <goldsimon>
Group administrator
Sun 29 Apr 2007 09:31:06 PM UTC, comment #1: 

Agree with you, I have already talk about that in a thread's forum "ETH_PAD_SIZE" near 5th July 2006 :

http://lists.gnu.org/archive/html/lwip-users/2006-07/msg00021.html

Frédéric Bernon <fbernon>
Group Member
Sun 29 Apr 2007 05:03:36 PM UTC, original submission:  

I remember reading this somewhere already, but I think it was lwip_users and no change was made:

In etharp.h, ETH_PAD_SIZE is defined:
#ifndef ETH_PAD_SIZE
#define ETH_PAD_SIZE 0
#endif

before any file is included, resulting in ETH_PAD_SIZE always = 0. This is currently no big issue since opt.h seems to be included everywhere before etharp.h is included. Still it could become a problem.

I propose moving the above code below all includes and adding #include "lwip/opt.h" at the top of the file.

Simon Goldschmidt <goldsimon>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by fbernon (Posted a comment)
  • -email is unavailable- added by goldsimon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-04-30 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2007-04-29 goldsimon Attached File- Added etharp.h_ETH_PAD_SIZE.patch, #12621

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code