lwIP - A Lightweight TCP/IP stack - Patches: patch #5926, Use function pointers instead of...
You are not allowed to post comments on this tracker with your current authentication level.
patch #5926: Use function pointers instead of table index in api_lib/api_msg
Submitter: | Frédéric Bernon <fbernon> | ||
Submitted: | Thu 10 May 2007 02:58:33 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | fbernon | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Fri 11 May 2007 09:10:59 AM UTC, comment #10: |
Simon Goldschmidt <goldsimon> |
Fri 11 May 2007 09:01:14 AM UTC, comment #9: Ok, it's check in. About messages vs locking for core thread, and for thread-safe problem on a same socket, I propose you to open a new patch item if it's good for you... |
Frédéric Bernon <fbernon> |
Fri 11 May 2007 08:31:11 AM UTC, comment #8:
|
Simon Goldschmidt <goldsimon> |
Fri 11 May 2007 08:08:50 AM UTC, comment #7:
|
Frédéric Bernon <fbernon> |
Fri 11 May 2007 07:53:38 AM UTC, comment #6:
|
Simon Goldschmidt <goldsimon> |
Fri 11 May 2007 07:42:17 AM UTC, comment #5:
|
Frédéric Bernon <fbernon> |
Fri 11 May 2007 07:15:24 AM UTC, comment #4: I think replacing the 'type' field with a 'function' field is rather straightforward and that part of the patch looks good to me.
|
Simon Goldschmidt <goldsimon> |
Thu 10 May 2007 07:10:01 PM UTC, comment #3: If no objections, I will check in tomorrow + comment #2...
|
Frédéric Bernon <fbernon> |
Thu 10 May 2007 03:50:04 PM UTC, comment #2: I we don't need TCP, but we need the sockets API, I propose to patch lwip_sendto like this :
|
Frédéric Bernon <fbernon> |
Thu 10 May 2007 03:18:32 PM UTC, comment #1: Ok, patch file is attached. Note I have also replace api_msg_post calls by calls to tcpip_apimsg (in current CVS, the first call directly the second one). I know that tcpip_apimsg could be "one next day" replaced by tcpip_callback, but, in a first time, I think it's simplify the code (because api_msg_post is really obsolete).
|
Frédéric Bernon <fbernon> |
Thu 10 May 2007 02:58:33 PM UTC, original submission:
Idea from "http://savannah.nongnu.org/patch/?5914" : we propose to include a function pointer instead of a table index in the message to reduce footprint. I prepare a patch file for that...
|
Frédéric Bernon <fbernon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-05-11 | fbernon | Status | Works For Me | Done | |
Open/Closed | Open | Closed | |||
2007-05-10 | fbernon | Attached File | - | Added api_msg.patch, #12746 | |
Status | None | Works For Me |
Powered by Savane 3.13-4448.
Corresponding source code
Good work.
Of course, this is not strictly realted to this patch. I'll open a new patch item once I find the time to work on it.