lwIP - A Lightweight TCP/IP stack - Patches: patch #6528, lwIP crash with large ICMP...
You are not allowed to post comments on this tracker with your current authentication level.
patch #6528: lwIP crash with large ICMP messages.
Submitter: | Bill Auerbach <billauerbach> | ||
Submitted: | Wed 28 May 2008 07:09:52 PM UTC | ||
Category: | None | Priority: | 7 - High |
Status: | Done | Privacy: | Public |
Assigned to: | jifl | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Wed 18 Feb 2009 04:55:29 PM UTC, comment #8: |
Simon Goldschmidt <goldsimon> |
Tue 17 Feb 2009 08:44:02 PM UTC, comment #7: OK, my bad, if I wanted that, I would have had to change mem_init(), too, to use the space, Jonathan, I guess your patch is fine. Can we commit it?
|
Simon Goldschmidt <goldsimon> |
Tue 17 Feb 2009 05:16:27 AM UTC, comment #6: I just remembered why ram_heap is MEM_SIZE_ALIGNED + (2*SIZEOF_STRUCT_MEM) + MEM_ALIGNMENT: I wanted the user to be able to allocate MEM_SIZE at minimum. And since we need one struct mem at the start and one at the end, we need 2*SIZEOF_STRUCT_MEM. Ok, maybe '+ MEM_ALIGMENT - 2' would be enough, but those 2 bytes... We can change that, but I prefer it the way it is now. |
Simon Goldschmidt <goldsimon> |
Thu 29 May 2008 09:05:31 PM UTC, comment #5: The change to ip_frag is fine as you'd expect. One question though and an observation:
|
Bill Auerbach <billauerbach> |
Thu 29 May 2008 12:18:00 PM UTC, comment #4: @Simon
|
Jonathan Larmour <jifl> |
Thu 29 May 2008 12:09:19 PM UTC, comment #3: Bill, since you sound keen ;-), care to try out the attached patch?
|
Jonathan Larmour <jifl> |
Thu 29 May 2008 10:49:45 AM UTC, comment #2: About mem.c:
|
Simon Goldschmidt <goldsimon> |
Thu 29 May 2008 02:28:54 AM UTC, comment #1: I've personally been excruciatingly busy recently, but had filed his post to look at later. I've looked at it now.
|
Jonathan Larmour <jifl> |
Wed 28 May 2008 07:09:52 PM UTC, original submission:
Problem: lwIP crash with large ICMP messages.
|
Bill Auerbach <billauerbach> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-02-18 | goldsimon | Status | In Progress | Done | |
Open/Closed | Open | Closed | |||
2008-05-29 | jifl | Status | None | In Progress | |
Assigned to | None | jifl | |||
2008-05-29 | jifl | Attached File | - | Added ip_frag2.diff, #15764 | |
2008-05-28 | billauerbach | Attached File | - | Added ip_frag.diff, #15760 |
Powered by Savane 3.13-02a9.
Corresponding source code
I've just comitted the changed size of 'buf' in ip_frag.c since I don't think there's any objection. I'll have another thought about mem.c