patchlwIP - A Lightweight TCP/IP stack - Patches: patch #6888, Patch for UDP Netbufs to support...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6888: Patch for UDP Netbufs to support dest-addr and dest-port

Submitter:  TabascoEye <tabascoeye>
Submitted:  Wed 05 Aug 2009 09:48:00 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  1.4.0

Wed 07 Oct 2009 05:59:20 PM UTC, comment #5: 

Checked in (something like that, at least; I think I made some changes...?).
Hope it doesn't interfere with 1.3.2, but it's only optional code, anyway. I had it on my disk for some time now...

Simon Goldschmidt <goldsimon>
Group administrator
Mon 24 Aug 2009 12:26:01 PM UTC, comment #4: 

Sorry, totally forgot about that (it's pretty new afterall)

I tried to clean it up a bit and it does not disturb the raw-API now.
I used a struct ip_addr instead of a pointer to one, so in total the patch adds 6Bytes to every netbuf.

Also I am assuming that the local_port in the pcb is the one the UDP header would contain (because I can't access the udp-header in that context, I think?). That might be a wrong assumption.

Open for comments...

(file #18633)

TabascoEye <tabascoeye>
Sat 22 Aug 2009 10:16:00 PM UTC, comment #3: 


> I made the changes as suggested by Simon.


Not really. I suggested using the new ip_current_header() to get the information, not changing the UDP raw API!

The rest of the patch seems OK.

Simon Goldschmidt <goldsimon>
Group administrator
Thu 20 Aug 2009 02:27:52 PM UTC, comment #2: 

My preference would be to add a new function to the API instead of changing the arguments to udp_recv() and refactor things such both functions can share a lot of the code, but I'm not sure how feasible that would be in this case.

Kieran Mansley <kieranm>
Group Member
Thu 20 Aug 2009 01:56:40 PM UTC, comment #1: 

I'd love to see this feature applied to 1.4.0
(plus I'd love to see 1.4.0 be released before/at the End of the year)

TabascoEye <tabascoeye>
Wed 05 Aug 2009 09:48:00 AM UTC, original submission:  

I made the changes as suggested by Simon.
Here is the diff. I put it all inside a #ifdef that is 0 for default so it should not change any behavior until activated.
Given that fact, now some function definitions look a bit ugly. I don't know your code style but this could be done prettier, I guess.

TabascoEye <tabascoeye>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #18633:  Netbufpatch_clean.diff added by tabascoeye (2KiB - application/octet-stream)
file #18529:  Netbufpatch.diff added by tabascoeye (6KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by kieranm (Posted a comment)
  • -email is unavailable- added by tabascoeye (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-10-07 goldsimon Open/ClosedOpen Closed
        StatusNone Done
        Assigned toNone goldsimon
    2009-08-24 tabascoeye Attached File- Added Netbufpatch_clean.diff, #18633
    2009-08-20 kieranm Planned ReleaseNone 1.4.0
    2009-08-20 kieranm Priority7 - High 5 - Normal
    2009-08-05 tabascoeye Attached File- Added Netbufpatch.diff, #18529

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code