lwIP - A Lightweight TCP/IP stack - Patches: patch #6900, IP Address Conversion Functions
You are not allowed to post comments on this tracker with your current authentication level.
patch #6900: IP Address Conversion Functions
Submitter: | Chris N. Strahm <cstrahm> | ||
Submitted: | Tue 25 Aug 2009 02:30:46 AM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | 1.4.0 |
Tue 25 Aug 2009 02:53:57 PM UTC, comment #4: |
Simon Goldschmidt <goldsimon> |
Tue 25 Aug 2009 10:47:56 AM UTC, comment #3:
|
Simon Goldschmidt <goldsimon> |
Tue 25 Aug 2009 10:47:04 AM UTC, comment #2: Since there is no inline statement in C (only in C++), I'd make it a define that passes on the address to inet_ntoa() (or a static function defined in ip_addr.h - much the same as inline). |
Simon Goldschmidt <goldsimon> |
Tue 25 Aug 2009 09:46:31 AM UTC, comment #1: I'm not sure I see the benefit here. It seems to avoid some type casting that works at the expense of more code. Perhaps it won't result in any more code actually being generated though. Could we make this an inline function to give the compiler a hint? |
Kieran Mansley <kieranm> |
Tue 25 Aug 2009 02:30:46 AM UTC, original submission:
Nice idea. A bug or patch entry at savannah makes sure this doesn't get forgotten. Thanks.
|
Chris N. Strahm <cstrahm> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-08-25 | goldsimon | Open/Closed | Open | Closed | |
Assigned to | None | goldsimon | |||
Status | None | Done | |||
2009-08-25 | goldsimon | Planned Release | None | 1.4.0 |
Powered by Savane 3.13-02a9.
Corresponding source code
Added #define ip_ntoa(addr) to ip_addr.h