patchlwIP - A Lightweight TCP/IP stack - Patches: patch #7844, contrib: Make unixsim apps compile

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7844: contrib: Make unixsim apps compile

Submitter:  Erik Ekman <yarrick>
Submitted:  Wed 05 Sep 2012 06:31:28 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Wed 26 Sep 2012 07:33:55 PM UTC, comment #5: 

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Wed 12 Sep 2012 10:47:05 AM UTC, comment #4: 

Here is a new patch (contrib-fix-unixsim-v2.patch) just fixing the use of a removed macro. After this fix all the unixsim targets compile for me (expect on that one box with the other errors).

(file #26541)

Erik Ekman <yarrick>
Group Member
Tue 11 Sep 2012 07:38:14 PM UTC, comment #3: 

Let's fix the code, not disable warnings.  I don't mind how picky the compiler is, it's probably right.

Kieran Mansley <kieranm>
Group Member
Thu 06 Sep 2012 09:51:39 PM UTC, comment #2: 

The patch I attached does two things.

1: Disables warnings as errors because on my 64bit box I get warnings like these because of macros:
http://lwip.kryo.se/builders/unixsim-linux64/builds/51/steps/simhost/logs/stdio
(Maybe this compiler is a bit extra picky, it is a null check done on the address to a stack variable that will always be ok)

2: Fix the warning I get on my 32bit box:
http://lwip.kryo.se/builders/unixsim-linux/builds/26/steps/simnode/logs/stdio

Should I create a new patch with only the second part?

Erik Ekman <yarrick>
Group Member
Thu 06 Sep 2012 07:38:55 PM UTC, comment #1: 


> The unixsim makefile treated warnings as errors which didnt go
> well together with no maintenance.


I guess it will continue to treat warnings as errors. A patch that fixes these warnings (or at least tells us what they are) would be welcome, though. :-)

Simon Goldschmidt <goldsimon>
Group administrator
Wed 05 Sep 2012 06:31:28 PM UTC, original submission:  

The unixsim makefile treated warnings as errors which didnt go well together with no maintenance. Also, a TCP header macro had to be updated.

Erik Ekman <yarrick>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #26541:  contrib-fix-unixsim-v2.patch added by yarrick (1KiB - text/x-patch - New patch fixing TCPH_OFFSET macro usage only)
file #26481:  contrib-fix-unixsim.patch added by yarrick (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by kieranm (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by yarrick (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-26 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2012-09-12 yarrick Attached File- Added contrib-fix-unixsim-v2.patch, #26541
    2012-09-05 yarrick Attached File- Added contrib-fix-unixsim.patch, #26481

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code