patchlwIP - A Lightweight TCP/IP stack - Patches: patch #8220, SNMP - proper const qualification...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8220: SNMP - proper const qualification for mib-2.system.sysDescr

Submitter:  Freddie Chopin <freddie_chopin>
Submitted:  Sat 26 Oct 2013 06:04:27 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Tue 14 Jan 2014 08:54:00 PM UTC, comment #1: 

Applied, thanks.

Simon Goldschmidt <goldsimon>
Group administrator
Sat 26 Oct 2013 06:04:27 PM UTC, original submission:  

Following 3 patches are simple improvements for SNMP code. The rationale is that mib-2.system.sysDescr is read-only, while current SNMP code expects non-conts objects, which is a waste of RAM.

1. Fix a simple typo in function name.
2. Add proper const-qualifiers for copying functions (which I intend to replace with MEMCPY() in another patch series).
3. Add proper const-qualifiers for mib-2.system.sysDescr objects and snmp_set_sysdescr() parameters.

Compiled, run - works correctly.

Freddie Chopin <freddie_chopin>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #29479:  0001-SNMP-fix-typo-snmp_set_sysdesr-snmp_set_sysdescr.patch added by freddie_chopin (2KiB - application/octet-stream - patches against current master)
file #29480:  0003-SNMP-mib-2.system.sysDescr-is-read-only-so-add-const.patch added by freddie_chopin (2KiB - application/octet-stream - patches against current master)
file #29481:  0002-SNMP-source-of-ocstrncpy-and-objectidncpy-may-be-con.patch added by freddie_chopin (1KiB - application/octet-stream - patches against current master)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by freddie_chopin (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-01-14 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2013-10-26 freddie_chopin Attached File- Added 0001-SNMP-fix-typo-snmp_set_sysdesr-snmp_set_sysdescr.patch, #29479
        Attached File- Added 0003-SNMP-mib-2.system.sysDescr-is-read-only-so-add-const.patch, #29480
        Attached File- Added 0002-SNMP-source-of-ocstrncpy-and-objectidncpy-may-be-con.patch, #29481

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code