patchlwIP - A Lightweight TCP/IP stack - Patches: patch #8617, unix port minimal demo: bugfixes,...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8617: unix port minimal demo: bugfixes, clarity, enhancements

Submitter:  chrysn <chrysn>
Submitted:  Wed 11 Mar 2015 06:18:41 PM UTC
   
 
Category:  Contrib Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Planned Release:  None

Sat 14 Mar 2015 12:44:34 AM UTC, comment #1: 

Hello chrysn,

> unix mintapif: perror fix


Indeed, thank for this fix. Applied.


> unix mintapif: added option to use a persistant tap interface


Fine for me, that's even better with a compile time option and the attached documentation is a great bonus I really like ;-),  Applied.


> add README file to the unix port to give overview


YEAH!, thanks for that. Applied.


> unix port: rename archtecture defines (linux -> LWIP_UNIX_LINUX)


Indeed, thank for this fix. I fully agree Linux should be the default, openbsd/cygwin ports variant are probably rarely tested (not be me at least, and I'm a heavy user of the unix port for PPP tests) so they should not be the default. Applied.


Cheers,
Sylvain

Sylvain Rochet <gradator>
Group Member
Wed 11 Mar 2015 06:18:41 PM UTC, original submission:  

following up on bug bug #40245, i'm reviewing the whole mintapif / tapif situation.

there are four patches i'd like to propose for addition to the contrib branch:

  • fix a bug in error reporting
  • allow using preconfigured tap interfaces using the mintapif implementation
  • add some general documentation about what does what in the unix port (especially why there is tapif and mintapif, as this came up in #40245)
  • clarify the platform detail compile time flags


the patches are sufficiently close to each other that i'm reporting them as one, please see the attached git patches for details.

surprisingly, the part that is most intrusive is the compile time flag patch, as it renames the linux/openbsd/cygwin macros to LWIP_UNIX_LINUX etc. this is due to gcc compiler setting -Dlinux=1 by default, which caused the original setup to kind of work unmodified both on linux and openbsd. after this patch, openbsd users have to explicitly set pass UNIXARCH=OPENBSD to their make files, but so must all other non-default platform users.

chrysn <chrysn>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gradator (Posted a comment)
  • -email is unavailable- added by chrysn (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-14 gradator StatusNone Done
        Open/ClosedOpen Closed
    2015-03-11 chrysn Attached File- Added 0001-unix-mintapif-perror-fix.patch, #33310
        Attached File- Added 0003-add-README-file-to-the-unix-port-to-give-overview.patch, #33311
        Attached File- Added 0002-unix-mintapif-added-option-to-use-a-persistant-tap-i.patch, #33312
        Attached File- Added 0004-unix-port-rename-archtecture-defines-linux-LWIP_UNIX.patch, #33313

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code