patchlwIP - A Lightweight TCP/IP stack - Patches: patch #8739, ip4: routing: check peer for point...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8739: ip4: routing: check peer for point to point interfaces

Submitter:  Sylvain Rochet <gradator>
Submitted:  Sun 13 Sep 2015 06:02:11 PM UTC
   
 
Category:  IPv4 Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Thu 24 Sep 2015 07:10:17 PM UTC, comment #5: 

Well, the check is not that costly after all...

I've pushed it.

Simon Goldschmidt <goldsimon>
Group administrator
Wed 16 Sep 2015 08:47:32 PM UTC, comment #4: 


> Can we gate this with PPP or SIO or something?


Yes, that's why I didn't commit it right away, it adds code in a well used path.

I'm not sure if we can gate that, what about a custom user netif which isn't a broadcast interface (so it is a point-to-point interface) which isn't lwip SIO nor lwIP PPP ?  I don't really care but it might happen.

Sylvain

Sylvain Rochet <gradator>
Group Member
Wed 16 Sep 2015 08:40:34 PM UTC, comment #3: 

Oh. Now you see how ofen I use PPP ;-)

Can we gate this with PPP or SIO or something?

Simon Goldschmidt <goldsimon>
Group administrator
Wed 16 Sep 2015 08:19:44 PM UTC, comment #2: 

Nope. Point-to-point link are 2 /32 seeing and knowing each other. Netmask is 255.255.255.255.

Sylvain Rochet <gradator>
Group Member
Wed 16 Sep 2015 08:18:16 PM UTC, comment #1: 

Why would that be necessary? The "network mask matches?" check should still match on this netif, shouldn't it?

Simon Goldschmidt <goldsimon>
Group administrator
Sun 13 Sep 2015 06:02:11 PM UTC, original submission:  

gw netif field for point to point interfaces is the peer IP address.
Check if the destination is equals to the gw field of point to point
interfaces (broadcast flag is not set) when routing an IP packet.

Sylvain Rochet <gradator>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by gradator (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-09-24 goldsimon StatusNone Done
        Open/ClosedOpen Closed
    2015-09-13 gradator Attached File- Added 0001-ip4-routing-check-peer-for-point-to-point-interfaces.patch, #34870

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code