patchlwIP - A Lightweight TCP/IP stack - Patches: patch #8759, Fix shadowing of global declaration

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8759: Fix shadowing of global declaration

Submitter:  Erik Ekman <yarrick>
Submitted:  Mon 05 Oct 2015 09:16:26 AM UTC
   
 
Category:  PPP Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  gradator Open/Closed:  Closed
Planned Release:  None

Tue 06 Oct 2015 09:21:28 AM UTC, comment #5: 

Hi,

> I am trying to build on travis-ci.org and I can't reproduce the errors locally so that's why it is one at a time.


It can't use your lwIP branch published somewhere ? This way you'll be able to provide a patch with all necessary changes once for all.

Anyway, applied, thanks :)

Sylvain

Sylvain Rochet <gradator>
Group Member
Tue 06 Oct 2015 08:26:06 AM UTC, comment #4: 

Ok, one more.. :)

I am trying to build on travis-ci.org and I can't reproduce the errors locally so that's why it is one at a time. I have checked all the other polarssl headers and they should not be a problem now at least.

sha1 this time.

(file #35081)

Erik Ekman <yarrick>
Group Member
Tue 06 Oct 2015 07:58:19 AM UTC, comment #3: 

Applied. Thanks ;-)

Sylvain Rochet <gradator>
Group Member
Tue 06 Oct 2015 07:31:30 AM UTC, comment #2: 

Found one more in the same file.

(file #35080)

Erik Ekman <yarrick>
Group Member
Mon 05 Oct 2015 04:27:50 PM UTC, comment #1: 

Applied. Thanks.

Sylvain Rochet <gradator>
Group Member
Mon 05 Oct 2015 09:16:26 AM UTC, original submission:  

Found one more shadowing. md5.h has function md5(), shadowed by md5 variable in magic.c.

https://travis-ci.org/yarrick/lwip-merged/jobs/83648416

gcc -g -Wall -DLWIP_UNIX_LINUX -DLWIP_DEBUG -pedantic -Werror -Wparentheses -Wsequence-point -Wswitch-default -Wextra -Wundef -Wshadow -Wpointer-arith -Wcast-qual -Wc++-compat -Wwrite-strings -Wold-style-definition -Wcast-align -Wmissing-prototypes -Wredundant-decls -Wnested-externs -Wno-address -Wunreachable-code -Wuninitialized -Wlogical-op -I. -I../../../../apps/httpserver_raw -I../../../../apps/shell -I../../../../apps/tcpecho -I../../../../apps/udpecho -I../../../../apps/snmp_private_mib -I../../../../apps/tcpecho_raw -I../../../../../lwip/src/include -I../../../../ports/unix/include -I../../../../../lwip/src -c ../../../../../lwip/src/netif/ppp/magic.c

../../../../../lwip/src/netif/ppp/magic.c: In function ‘magic_churnrand’:

../../../../../lwip/src/netif/ppp/magic.c:105:15: error: declaration of ‘md5’ shadows a global declaration [-Werror=shadow]

../../../../../lwip/src/include/netif/ppp/polarssl/md5.h:88:6: error: shadowed declaration is here [-Werror=shadow]

../../../../../lwip/src/netif/ppp/magic.c: In function ‘magic_random_bytes’:

../../../../../lwip/src/netif/ppp/magic.c:165:15: error: declaration of ‘md5’ shadows a global declaration [-Werror=shadow]

../../../../../lwip/src/include/netif/ppp/polarssl/md5.h:88:6: error: shadowed declaration is here [-Werror=shadow]

cc1: all warnings being treated as errors

Erik Ekman <yarrick>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gradator (Posted a comment)
  • -email is unavailable- added by yarrick (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-10-06 yarrick Attached File- Added 0001-PPP-Fix-shadowing-of-global-declaration-sha1.patch, #35081
    2015-10-06 yarrick Attached File- Added PPP-Fix-shadowing-of-global-declaration-2.patch, #35080
    2015-10-05 gradator StatusNone Done
        Assigned toNone gradator
        Open/ClosedOpen Closed
    2015-10-05 yarrick Attached File- Added 0001-PPP-Fix-shadowing-of-global-declaration.patch, #35072

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code