lwIP - A Lightweight TCP/IP stack - Patches: patch #8852, Optimize udp_bind code paths
You are not allowed to post comments on this tracker with your current authentication level.
patch #8852: Optimize udp_bind code paths
Submitter: | Axel Lin <axellin> | ||
Submitted: | Tue 12 Jan 2016 01:22:59 AM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | None | Open/Closed: | Closed |
Planned Release: | None |
Wed 13 Jan 2016 12:26:11 AM UTC, comment #3: |
Axel Lin <axellin> |
Tue 12 Jan 2016 08:31:12 PM UTC, comment #2: Just saw the same objection may apply to patch 1 |
Dirk Ziegelmeier <dziegel> |
Tue 12 Jan 2016 08:28:59 PM UTC, comment #1: Patch 2: Are you sure the line " } else if (rebind == 0) {" is correct? The check for collisions with other PCB should also be done when rebinding - the user could have chosen a port that is in use. Also note the IPv4/IPv6 is also checked in the comparison.
|
Dirk Ziegelmeier <dziegel> |
Tue 12 Jan 2016 01:22:59 AM UTC, original submission:
[PATCH 1/2] udp_bind: Slightly optimize the rebind code path
|
Axel Lin <axellin> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-01-13 | dziegel | Status | None | Done | |
Open/Closed | Open | Closed | |||
2016-01-13 | axellin | Attached File | - | Added 0001-udp_bind-Omit-checking-for-the-same-port-if-no-port-.patch, #36003 | |
2016-01-12 | axellin | Attached File | - | Added 0001-udp_bind-Slightly-optimize-the-rebind-code-path.patch, #35994 | |
Attached File | - | Added 0002-udp_bind-Optimize-the-code-patch-for-checking-port-c.patch, #35995 |
Powered by Savane 3.13-02a9.
Corresponding source code
Hi Dirk,
I also found a problem in patch1.
It should not break out immediately because it needs to check port collisions with rest of the active pcbs.
So please ignore this serial.
Thanks for the review, I'll try to fix it again.