patchlwIP - A Lightweight TCP/IP stack - Patches: patch #8861, raw: Remove unnecessary #if guard...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8861: raw: Remove unnecessary #if guard around PCB_ISIPV6() calls

Submitter:  Axel Lin <axellin>
Submitted:  Sat 16 Jan 2016 01:52:08 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Planned Release:  None

Mon 18 Jan 2016 01:54:36 PM UTC, comment #1: 

The library example in contrib/ports/unix/proj/lib no longer builds:

gcc -g -Wall -DLWIP_UNIX_LINUX -DLWIP_DEBUG -pedantic -Werror -Wparentheses -Wsequence-point -Wswitch-default -Wextra -Wundef -Wshadow -Wpointer-arith -Wcast-qual -Wc++-compat -Wwrite-strings -Wold-style-definition -Wcast-align -Wmissing-prototypes -Wredundant-decls -Wnested-externs -Wno-address -Wunreachable-code -Wuninitialized -Wlogical-op -I. -I../../../.. -I../../../../../lwip/src/include -I../../../../ports/unix/include -fPIC -c ../../../../../lwip/src/core/raw.c
../../../../../lwip/src/core/raw.c: In function 'raw_sendto':
../../../../../lwip/src/core/raw.c:249:35: error: 'IP6_HLEN' undeclared (first use in this function)
   header_size = PCB_ISIPV6(pcb) ? IP6_HLEN : IP_HLEN;
                                   ^
../../../../../lwip/src/core/raw.c:249:35: note: each undeclared identifier is reported only once for each function it appears in
../Common.mk:84: recipe for target 'raw.o' failed

Erik Ekman <yarrick>
Group Member
Sat 16 Jan 2016 01:52:08 AM UTC, original submission:  

PCB_ISIPV6() macro is well defined for all cases (LWIP_IPV4 && LWIP_IPV6,
LWIP_IPV4 only and LWIP_IPV6 only), thus remove the unnecessary #if guard
around PCB_ISIPV6() calls.

Axel Lin <axellin>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by yarrick (Posted a comment)
  • -email is unavailable- added by dziegel (Updated the item)
  • -email is unavailable- added by axellin (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-01-18 dziegel StatusNone Done
        Open/ClosedOpen Closed
    2016-01-16 axellin Attached File- Added 0001-raw-Remove-unnecessary-if-guard-around-PCB_ISIPV6-ca.patch, #36053

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code