lwIP - A Lightweight TCP/IP stack - Patches: patch #8911, Optimize lwip_selscan()
You are not allowed to post comments on this tracker with your current authentication level.
patch #8911: Optimize lwip_selscan()
Submitter: | Joel Cunningham <jcunningham> | ||
Submitted: | Wed 17 Feb 2016 10:43:51 PM UTC | ||
Category: | sockets/netconn | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | jcunningham | Open/Closed: | Closed |
Planned Release: | None |
Thu 18 Feb 2016 07:19:34 PM UTC, comment #4: |
Joel Cunningham <jcunningham> |
Thu 18 Feb 2016 06:11:51 PM UTC, comment #3: I thought, you'd just push it... :-) |
Simon Goldschmidt <goldsimon> |
Thu 18 Feb 2016 03:16:05 PM UTC, comment #2: Thanks, I moved them so they aren't initialized every loop iteration. Good call on moving to if(sock != NULL). Patch 2 makes the suggested change |
Joel Cunningham <jcunningham> |
Thu 18 Feb 2016 10:05:31 AM UTC, comment #1: Nice improvement. Only I don't see why you moved the scope of the four variables out of the lop? Couldn't they even be moved into the "if(sock != NULL)" block? |
Simon Goldschmidt <goldsimon> |
Wed 17 Feb 2016 10:43:51 PM UTC, original submission:
This patch makes a couple of simple re-arrangements in lwip_selscan() that
|
Joel Cunningham <jcunningham> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-02-23 | goldsimon | Open/Closed | Open | Closed | |
2016-02-18 | jcunningham | Status | None | Done | |
Assigned to | None | jcunningham | |||
2016-02-18 | jcunningham | Attached File | - | Added 0002-Optimize-lwip_selscan.patch, #36386 | |
2016-02-17 | jcunningham | Attached File | - | Added 0001-Optimize-lwip_selscan.patch, #36369 |
Powered by Savane 3.13-caa5.
Corresponding source code
Submitted, thanks