patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9125, tcp: fix FIN ACK handling with...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9125: tcp: fix FIN ACK handling with unsent data

Submitter:  David van Moolenbroek <dcvmoole>
Submitted:  Thu 29 Sep 2016 08:01:58 PM UTC
   
 
Category:  TCP Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Tue 04 Oct 2016 08:14:24 PM UTC, comment #3: 

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Fri 30 Sep 2016 09:46:12 AM UTC, comment #2: 

Ah, my apologies. Will do that from now on.

David van Moolenbroek <dcvmoole>
Fri 30 Sep 2016 06:18:39 AM UTC, comment #1: 


> Description in patch.


Please post descriptions here, not only in patch files. You cannot view the contents of attached files on all platforms. I'll dothis for you now:

TCP's snd_nxt represents the next sequence number after sent data, and as such does not cover any unsent data queued on the connection.  The current implementation does not take the latter point into account when processing FIN acknowledgments, mistakenly assuming that an outgoing FIN is ACK'ed when the acknowledgment covers up to snd_nxt while there is still unsent data.  This patch adds a check for unsent data to correct this, effectively preventing that TCP connections are closed prematurely.

Simon Goldschmidt <goldsimon>
Group administrator
Thu 29 Sep 2016 08:01:58 PM UTC, original submission:  

There seem to be some places in lwIP's TCP implementation that assume snd_nxt covers more than it does (see also bug #49128). Here is another, rather serious case, fortunately with an easy fix. Description in patch.

David van Moolenbroek <dcvmoole>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by dcvmoole (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-10-04 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2016-09-29 dcvmoole Attached File- Added 0001-tcp-fix-FIN-ACK-handling-with-unsent-data.patch, #38623

    Back to the top

    Powered by Savane 3.13-aa77.
    Corresponding source code