lwIP - A Lightweight TCP/IP stack - Patches: patch #9164, Add option to set and use peer DNS...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9164: Add option to set and use peer DNS server
Submitter: | Ajay Bhargav <ajaybhargav> | ||
Submitted: | Thu 17 Nov 2016 11:09:49 AM UTC | ||
Category: | PPP | Priority: | 5 - Normal |
Status: | Wont Do | Privacy: | Public |
Assigned to: | gradator | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Thu 17 Nov 2016 08:09:30 PM UTC, comment #8: |
Sylvain Rochet <gradator> |
Thu 17 Nov 2016 02:44:30 PM UTC, comment #7: I understand completely. For me a better way could be to have settings defined as a const pointer (save ram too) in case someone configure ppp parameters and do not want to change them later on. Most of the time there is only single ppp connection in an embedded device and settings can be assigned when pcb is allocated. This is where only compile time options are needed no runtime options. |
Ajay Bhargav <ajaybhargav> |
Thu 17 Nov 2016 01:53:59 PM UTC, comment #6: Simon took the words right out of my mouth here :-)
|
Sylvain Rochet <gradator> |
Thu 17 Nov 2016 12:56:13 PM UTC, comment #5: Sure.. we can drop this. |
Ajay Bhargav <ajaybhargav> |
Thu 17 Nov 2016 12:53:13 PM UTC, comment #4: We don't want more and more config options unless they have significant impact on code size or something else.
|
Simon Goldschmidt <goldsimon> |
Thu 17 Nov 2016 12:50:49 PM UTC, comment #3: Ajay says, by email outside bug tracker:
|
Sylvain Rochet <gradator> |
Thu 17 Nov 2016 11:27:39 AM UTC, comment #2: I see most of the PPP settings are part of lwipopt.h so having this in the same place will make sense.
|
Ajay Bhargav <ajaybhargav> |
Thu 17 Nov 2016 11:14:35 AM UTC, comment #1: Hello Ajay,
|
Sylvain Rochet <gradator> |
Thu 17 Nov 2016 11:09:49 AM UTC, original submission:
usepeerdns setting of PPP is never set and there was no option to enable it either. This patch add a new PPP option "PPP_USEPEERDNS" which is enabled when LWIP_DNS is enabled and will set pcb->settings.usepeerdns setting in PPP pcb.
|
Ajay Bhargav <ajaybhargav> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-11-17 | goldsimon | Status | None | Wont Do | |
Open/Closed | Open | Closed | |||
2016-11-17 | dziegel | Status | Need Info | None | |
2016-11-17 | gradator | Status | None | Need Info | |
Assigned to | None | gradator | |||
2016-11-17 | ajaybhargav | Attached File | - | Added 0001-ppp-Add-option-to-set-and-use-peer-DNS-server.patch, #39001 |
Powered by Savane 3.13-caa5.
Corresponding source code
Hi,
I agree with you but lwIP users should not have to access struct members directly, it means generating a const configuration struct must be done by only using macros. I'm not saying it's not possible but this is going to be a pain.
About RAM usage, ppp_settings is 48 byte long with all features enabled with 64-bit alignment. ppp struct itself is more than 1000 byte long with minimal feature set (> 7000 byte long with all features enabled). I'm not sure it's worth it :)
I see the point, but this is not always true, for example you could have two identical systems communicating over PPPoS with a DIP switch to select which one is PPP server and which one is PPP client.
Sylvain