lwIP - A Lightweight TCP/IP stack - Patches: patch #9166, Fix oldest entry lookup in...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9166: Fix oldest entry lookup in dns_enqueue
Submitter: | Giuseppe Andreello <andreello> | ||
Submitted: | Fri 18 Nov 2016 07:13:42 PM UTC | ||
Category: | DNS | Priority: | 5 - Normal |
Status: | Duplicate | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | None |
Wed 23 Nov 2016 08:06:32 AM UTC, comment #4: |
Simon Goldschmidt <goldsimon> |
Wed 23 Nov 2016 12:58:25 AM UTC, comment #3: Hi Simon,
|
Giuseppe Andreello <andreello> |
Tue 22 Nov 2016 08:25:40 PM UTC, comment #2: Plus, I've tested it (without your patch; in win32 debugger) and it works for me:
|
Simon Goldschmidt <goldsimon> |
Tue 22 Nov 2016 08:07:55 PM UTC, comment #1: This is one very strange diff you attached: what's this dns_can_recycle_entry() function? |
Simon Goldschmidt <goldsimon> |
Fri 18 Nov 2016 07:13:42 PM UTC, original submission:
If dns_seqno wraps around, dns_enqueue does not compute the age of the entries correctly, and can return ERR_MEM even if there are recyclable entries. |
Giuseppe Andreello <andreello> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-11-23 | goldsimon | Status | Works For Me | Duplicate | |
Open/Closed | Open | Closed | |||
2016-11-22 | goldsimon | Status | None | Works For Me | |
Assigned to | None | goldsimon | |||
2016-11-18 | andreello | Attached File | - | Added dns_enqueue.diff, #39013 |
Powered by Savane 3.13-02a9.
Corresponding source code
That function does not exist in original lwIP (and never existed). That means you have some 3rd party version, which I don't want to support (and this is why your patch doesn't apply).
As to your bug report: that bug has already been fixed back in 2014 (patch #8480) by casting the result of the subtraction to u8_t.