patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9218, ICMPv6 should always have...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9218: ICMPv6 should always have checksums generated

Submitter:  Knut Tidemann <knutt>
Submitted:  Wed 11 Jan 2017 11:20:20 AM UTC
   
 
Category:  IPv6 Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Planned Release:  None

Wed 11 Jan 2017 11:30:47 AM UTC, comment #1: 

Thanks for the patch!

Explanation for reference from RFC 3542, chapter 1:

   2. Some basic semantic definitions for IPv6 raw sockets.  For
      example, a raw ICMPv4 socket requires the application to calculate
      and store the ICMPv4 header checksum.  But with IPv6 this would
      require the application to choose the source IPv6 address because
      the source address is part of the pseudo header that ICMPv6 now
      uses for its checksum computation.  It should be defined that with
      a raw ICMPv6 socket the kernel always calculates and stores the
      ICMPv6 header checksum.

Dirk Ziegelmeier <dziegel>
Group administrator
Wed 11 Jan 2017 11:20:20 AM UTC, original submission:  

As per RFC 3542 chapter 3.1 ( https://www.ietf.org/rfc/rfc3542.txt ), the stack should always calculate checksums for ICMPv6 packets. This is not an optional feature.

This patch enabled IPV6_CHECKSUM when a raw socket is created with protocol IPPROTO_ICMPV6 and returns EINVALID if a user tries to change it as per the RFC.

Knut Tidemann <knutt>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by knutt (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-01-11 dziegel StatusNone Done
        Open/ClosedOpen Closed
    2017-01-11 knutt Attached File- Added 0001-lwip-fix-broken-default-ICMPv6-handling-of-checksums.patch, #39432

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code