patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9274, SNMPv3 improvements

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9274: SNMPv3 improvements

Submitted by:  Marco Veeneman <mave>
Submitted on:  Wed 01 Mar 2017 04:16:15 PM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Planned Release:  None

( Jump to the original submission)

Thu 02 Mar 2017 07:29:28 AM UTC, comment #6: 

Thanks for accepting the patches! I see i should really pay more attention to the LwIP coding style.. I'm sorry guys.

Marco Veeneman <mave>
Wed 01 Mar 2017 08:12:49 PM UTC, comment #5: 

I'm going to fix the C++ style comments
Tabs have already been fixed

Dirk Ziegelmeier <dziegel>
Project Administrator
Wed 01 Mar 2017 07:55:39 PM UTC, comment #4: 

BTW: https://travis-ci.org/yarrick/lwip-merged seems to fail now, but it gives me an error trying to fetch the logs..

Simon Goldschmidt <goldsimon>
Project Administrator
Wed 01 Mar 2017 07:53:48 PM UTC, comment #3: 

I have some things to add (if only for the next patches):
- 2 spaces, not tabs!
- C comments, not C++!
- the name "tcpip_enginetime_timer()" is not appropriate for snmpv3_priv.h

The rest looks good ;-) (from viewing the code, not testing)

Simon Goldschmidt <goldsimon>
Project Administrator
Wed 01 Mar 2017 07:41:33 PM UTC, comment #2: 

I pushed your patches together with a some compile fixes without checking whether they work (I have no time for it at the moment). I disabled SNMPv3 for now.
Thanks for sharing your work!!!

Dirk Ziegelmeier <dziegel>
Project Administrator
Wed 01 Mar 2017 04:26:20 PM UTC, comment #1: 

continue my initial post..

5. Adds starting the enginetime timer in the netconn thread.

6. Implements the framework MIB

7. Implements the USM MIB.

8. Adds the framework and USM mib to the default mibs list.

9. Updates the snmpv3_dummy implementation.

Marco Veeneman <mave>
Wed 01 Mar 2017 04:16:15 PM UTC, original submission:  

I finally had time to create some patches of my work on SNMPv3 so far. Note that the patches are a first proposal, there may be more changes needed.

1. Removed usage of LWIP_SNMPV3_GET_ENGINE_BOOTS macro.

2. Added missing context specific snmp tags.

3. Runtime configurable snmp version.

4. Handle invalid snmpv3 packets.

Marco Veeneman <mave>

 

Attached Files
file #39870:  09_updated_snmpv3_dummy.diff added by mave (9KiB - application/octet-stream)
file #39866:  05_enginetime_timer.diff added by mave (1KiB - application/octet-stream)
file #39867:  06_framework_mib.diff added by mave (5KiB - application/octet-stream)
file #39868:  07_usm_mib.diff added by mave (17KiB - application/octet-stream)
file #39862:  01_snmpv3_build_priv_param.diff added by mave (885B - application/octet-stream)
file #39863:  02_missing_context_specific_tags.diff added by mave (1KiB - application/octet-stream)
file #39864:  03_runtime_configurable_snmp_version.diff added by mave (5KiB - application/octet-stream)
file #39865:  04_handle_invalid_snmpv3_packets.diff added by mave (20KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by mave (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-03-01 dziegel StatusNone => Done
        Open/ClosedOpen => Closed
    2017-03-01 mave Attached File- => Added 09_updated_snmpv3_dummy.diff, #39870
    2017-03-01 mave Attached File- => Added 05_enginetime_timer.diff, #39866
        Attached File- => Added 06_framework_mib.diff, #39867
        Attached File- => Added 07_usm_mib.diff, #39868
        Attached File- => Added 08_add_framework_and_usm_mib_to_default_mibs.diff, #39869
    2017-03-01 mave Attached File- => Added 01_snmpv3_build_priv_param.diff, #39862
        Attached File- => Added 02_missing_context_specific_tags.diff, #39863
        Attached File- => Added 03_runtime_configurable_snmp_version.diff, #39864
        Attached File- => Added 04_handle_invalid_snmpv3_packets.diff, #39865

    Back to the top


    Powered by Savane 3.5