lwIP - A Lightweight TCP/IP stack - Patches: patch #9283, Returning access modes with fcntl
You are not allowed to post comments on this tracker with your current authentication level.
patch #9283: Returning access modes with fcntl
Submitter: | Joan Lledó <jllledo> | ||
Submitted: | Fri 10 Mar 2017 06:57:36 PM UTC | ||
Category: | sockets/netconn | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Wed 29 Mar 2017 06:54:57 PM UTC, comment #12: |
Simon Goldschmidt <goldsimon> |
Wed 29 Mar 2017 10:51:46 AM UTC, comment #11: I've added the lock to access the pcb, but now it will return nothing for TCP sockets if LWIP_TCPIP_CORE_LOCKING is not set.
|
Joan Lledó <jllledo> |
Tue 28 Mar 2017 08:27:21 PM UTC, comment #10: That looks a bit better.
|
Simon Goldschmidt <goldsimon> |
Tue 28 Mar 2017 04:56:07 PM UTC, comment #9: Hello Simon,
|
Joan Lledó <jllledo> |
Mon 27 Mar 2017 11:12:20 AM UTC, comment #8: Hmm, that patch does not check for null pointers, does not care for threading/locking issues and does not return anything for udp/raw sockets... |
Simon Goldschmidt <goldsimon> |
Thu 23 Mar 2017 08:48:07 PM UTC, comment #7: Hi,
|
Joan Lledó <jllledo> |
Thu 23 Mar 2017 09:43:22 AM UTC, comment #6: We do have other linux specialities, so if it's small, I'm OK with adding it...
|
Simon Goldschmidt <goldsimon> |
Wed 22 Mar 2017 10:09:21 PM UTC, comment #5: Hi Simon,
|
Joan Lledó <jllledo> |
Wed 22 Mar 2017 09:44:23 PM UTC, comment #4: Any progress or should I close this? |
Simon Goldschmidt <goldsimon> |
Sun 12 Mar 2017 07:22:50 PM UTC, comment #3: Hi Simon, thanks for your comments.
|
Joan Lledó <jllledo> |
Fri 10 Mar 2017 09:13:30 PM UTC, comment #2: EAM should have been RAM. My smartphone somehow changed that :-) |
Simon Goldschmidt <goldsimon> |
Fri 10 Mar 2017 09:07:18 PM UTC, comment #1: No, that's not the proper way. Not because you break things but because you increased EAM usage of each socket. The proper way would be to get the state from the underlying PCB or netconn.
|
Simon Goldschmidt <goldsimon> |
Fri 10 Mar 2017 06:57:36 PM UTC, original submission:
Hello,
|
Joan Lledó <jllledo> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-03-29 | goldsimon | Status | None | Done | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2017-03-29 | jllledo | Attached File | - | Added 0001-lwip_fcntl-returns-access-modes.patch, #40190 | |
2017-03-28 | jllledo | Attached File | - | Added 0001-lwip_fcntl-returns-access-modes.patch, #40182 | |
2017-03-23 | jllledo | Attached File | - | Added 0001-lwip_fcntl-returns-access-modes.patch, #40101 | |
2017-03-10 | jllledo | Attached File | - | Added 0001-fcntl-returns-access-modes.patch, #39968 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Pushed (and slightly improved). Thanks for the patch.