patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9373, apps/smtp: Don't allow pass NULL...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9373: apps/smtp: Don't allow pass NULL to smtp_set_server_addr

Submitter:  Axel Lin <axellin>
Submitted:  Wed 07 Jun 2017 07:03:17 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Tue 13 Jun 2017 08:06:22 PM UTC, comment #1: 

I'd rather clear the old setting for NULL.
Fixed that way, thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Wed 07 Jun 2017 07:03:17 AM UTC, original submission:  

The meaning of passing NULL to smtp_set_server_addr is ambiguous.
It does not clear the old setting.
Thus make it return error if server is NULL.
This also avoid calling MEMCPY with NULL even when len = 0.

Axel Lin <axellin>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by axellin (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-06-13 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2017-06-07 axellin Attached File- Added 0001-apps-smtp-Don-t-allow-pass-NULL-to-smtp_set_server_a.patch, #40872

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code