patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9378, apps/smtp: Fix server argument...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9378: apps/smtp: Fix server argument length checking

Submitter:  Axel Lin <axellin>
Submitted:  Wed 14 Jun 2017 01:19:58 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Planned Release:  None

Wed 14 Jun 2017 08:08:28 PM UTC, comment #1: 

I'd like to keep strnlen, so I fixed it in another way. Thanks for reporting!

Dirk Ziegelmeier <dziegel>
Group administrator
Wed 14 Jun 2017 01:19:58 PM UTC, original submission:  

The strnlen() function returns strlen(s), if that is less than maxlen, or maxlen if there is no null terminating ('\0') among the first maxlen characters pointed to by s.

We cannot detect if server argument is too long with strnlen() because len never greater than SMTP_MAX_SERVERNAME_LEN.
Switch back to strlen() instead.

Axel Lin <axellin>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by axellin (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-06-14 dziegel StatusNone Done
        Open/ClosedOpen Closed
    2017-06-14 axellin Attached File- Added 0001-apps-smtp-Fix-server-length-checking.patch, #40919

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code