patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9382, the comparison will always...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9382: the comparison will always evaluate as 'true' for the address of 'tmpaddr' will never be NULL [-Waddress]

Submitter:  Martin Haefner <mhaef>
Submitted:  Wed 21 Jun 2017 08:58:18 AM UTC
   
 
Category:  None Priority:  3 - Low
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Thu 22 Jun 2017 05:14:37 AM UTC, comment #5: 

Sounds nice.
As I said, patch was just a hack for the compiler.
But I reached what I want to have.
Continuous integration builds are green again :-)

Martin Haefner <mhaef>
Wed 21 Jun 2017 07:51:42 PM UTC, comment #4: 

FYI: I'm in the progress of making the whole stack work with -Waddress...

Simon Goldschmidt <goldsimon>
Group administrator
Wed 21 Jun 2017 11:27:30 AM UTC, comment #3: 

Done (my way), so the warning should be fixed now.

Simon Goldschmidt <goldsimon>
Group administrator
Wed 21 Jun 2017 11:17:05 AM UTC, comment #2: 

That patch is really ugly :-)

> I think that should call ip_addr_debug_print_val() instead.


Indeed. I'll fix it that way.

Simon Goldschmidt <goldsimon>
Group administrator
Wed 21 Jun 2017 09:07:19 AM UTC, comment #1: 

I think that should call ip_addr_debug_print_val() instead.

I had similar warning and I fixed it locally as below:
https://savannah.nongnu.org/patch/?func=detailitem&item_id=9289#options

Axel Lin <axellin>
Group Member
Wed 21 Jun 2017 08:58:18 AM UTC, original submission:  

Hi there,

have some gcc warnings with the latest master branch.
Attached patch cheats the compiler.
Maybe it is useful.

Regards

Martin Haefner <mhaef>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #40961:  gccwarning.patch added by mhaef (1KiB - application/octet-stream - cheat gcc warning)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by axellin (Posted a comment)
  • -email is unavailable- added by mhaef (Submitted the item)
  • -email is unavailable- added by mhaef
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-06-21 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2017-06-21 mhaef Attached File- Added gccwarning.patch, #40961
        Carbon-Copy- Added mhaef

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code