patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9388, Increase SNTP retry timeout to be...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9388: Increase SNTP retry timeout to be conform with RFC 4330.

Submitter:  Matthias Hofmann <mhofmann>
Submitted:  Fri 23 Jun 2017 07:35:57 AM UTC
   
 
Category:  apps Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Jump to the original submission

Tue 25 Jul 2017 06:53:12 PM UTC, comment #6: 

The new patch looks better. Pushed. Thanks for insisting :-)

Simon Goldschmidt <goldsimon>
Group administrator
Tue 25 Jul 2017 06:48:01 PM UTC, comment #5: 


> As I understand the RFC the 15+ minute timeout in chapter 10 is the maximum timeout.
> So the limit for the exponential backoff algorithm.


That would be the opposite of the RFC's wording. Although there is nothing about chapter 10 in the errata.

As I understand, the 15+ minutes is the cyclic (planned) time update, whereas the >= 15 seconds is the retry if a planned time update goes unanswered.

Simon Goldschmidt <goldsimon>
Group administrator
Tue 25 Jul 2017 11:42:55 AM UTC, comment #4: 

Ok, I changed the patch and increased SNTP_RECV_TIMEOUT.

As I understand the RFC the 15+ minute timeout in chapter 10 is the maximum timeout. So the limit for the exponential backoff algorithm.

And the 15+ seconds timeout is the lower limit for any polling action.


(file #41329)

Matthias Hofmann <mhofmann>
Tue 27 Jun 2017 07:06:14 PM UTC, comment #3: 

As I read that, the part with 1 minute is meant for time update. This is set to 1 hour in our implementation (SNTP_UPDATE_DELAY).

However, chapter 10 says the poll intervall MUST NOT be less than 15 seconds. We use 3 seconds here, so that should be changed. However, your patch doesn't do this.

And finally, later chapter 10 requires to nevers set "the timeout" less than 15 minutes (although without any upper case word).

Now I'm confused!

Simon Goldschmidt <goldsimon>
Group administrator
Mon 26 Jun 2017 05:42:00 AM UTC, comment #2: 

Okey not my best english... According to RFC 4330, section 5: Under no conditions NTP requests shall be send with an interval of less than 1 minute.

The maximum retry interval is currently 30 seconds, thus it is quite hard to achive a transmission interval of 60 seconds or more. Thats why this patch.

Matthias Hofmann <mhofmann>
Fri 23 Jun 2017 07:10:38 PM UTC, comment #1: 

This sounds kind of funny. You're talking about the minimum of 1 minute but change the define for the maximum??

Obviously, I can't apply this :-)

Simon Goldschmidt <goldsimon>
Group administrator
Fri 23 Jun 2017 07:35:57 AM UTC, original submission:  

According to RFC 4330 under any condition NTP requests shall be transmitted with a minimum interval of 1 minute.

Increase the maximum retry timeout to be conform to this requirement.

Matthias Hofmann <mhofmann>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #41033:  0001-Increase-SNTP_RETRY_TIMEOUT_MAX.patch added by mhofmann (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by mhofmann (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-07-25 mhofmann Attached File- Added 0001-Increase-SNTP_RECV_TIMEOUT-to-be-conform-with-RFC.patch, #41329
    2017-06-23 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2017-06-23 mhofmann Attached File- Added 0001-Increase-SNTP_RETRY_TIMEOUT_MAX.patch, #41033

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code