lwIP - A Lightweight TCP/IP stack - Patches: patch #9447, ping: guard ping_time with...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9447: ping: guard ping_time with LWIP_DEBUG
Submitter: | Joel Cunningham <jcunningham> | ||
Submitted: | Mon 28 Aug 2017 05:32:26 PM UTC | ||
Category: | apps | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | jcunningham | Open/Closed: | Closed |
Planned Release: | None |
Mon 28 Aug 2017 09:14:13 PM UTC, comment #4: |
Joel Cunningham <jcunningham> |
Mon 28 Aug 2017 07:32:03 PM UTC, comment #3: Right. I wonder if it's possible to improve those debugf defines depending more on the actual module's debug setting... I failed so far... |
Simon Goldschmidt <goldsimon> |
Mon 28 Aug 2017 06:59:08 PM UTC, comment #2:
|
Joel Cunningham <jcunningham> |
Mon 28 Aug 2017 05:55:23 PM UTC, comment #1: Hmm, it makes thinigs a little better, but there's still the chance that debug is disabled via PING_DEBUG or even that LWIP_PLATFORM_DIAG isn't proberly defined.
|
Simon Goldschmidt <goldsimon> |
Mon 28 Aug 2017 05:32:26 PM UTC, original submission:
Attached patch, commit message:
|
Joel Cunningham <jcunningham> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-08-28 | jcunningham | Status | None | Done | |
Open/Closed | Open | Closed | |||
2017-08-28 | jcunningham | Attached File | - | Added 0001-ping-guard-ping_time-with-LWIP_DEBUG.patch, #41689 |
Powered by Savane 3.13-02a9.
Corresponding source code
I would be nice to have the module define (i.e. PING_DEBUG) control compiling out the LWIP_DEBUGF call, but I'm not sure how to do that. A #define can't have further #if/#endif within it