patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9498, Get rid of raw_flags() and...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9498: Get rid of raw_flags() and udp_flags() macro

Submitter:  Axel Lin <axellin>
Submitted:  Thu 23 Nov 2017 03:31:02 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Thu 23 Nov 2017 09:15:43 PM UTC, comment #1: 

Pushed the sockets.c changes.

However, we can't just remove raw_flags() and udp_flags(). This is part of the API. raw/udp_setflags() are the corresponding setter functions (you didn't remove them either, and at least the udp part is actually used).

Just because the stack doesn't use it internally doesn't mean we can remove it.

Simon Goldschmidt <goldsimon>
Group administrator
Thu 23 Nov 2017 03:31:02 PM UTC, original submission:  

All current udp_flags() use cases can be replaced by udp_is_flag_set().
And there is no user calling raw_flags().
So remove raw_flags() and udp_flags() macro.

Axel Lin <axellin>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by axellin (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-11-23 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2017-11-23 axellin Attached File- Added 0001-Get-rid-of-raw_flags-and-udp_flags-macro.patch, #42462

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code