patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9538, netif: Remove unnecessary NULL...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9538: netif: Remove unnecessary NULL checking in netif_do_set_{ipaddr|netmask|gw}

Submitter:  Axel Lin <axellin>
Submitted:  Tue 09 Jan 2018 07:10:27 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Planned Release:  None

Tue 09 Jan 2018 07:46:07 AM UTC, comment #1: 

Good cleanup! Applied.

Dirk Ziegelmeier <dziegel>
Group administrator
Tue 09 Jan 2018 07:10:27 AM UTC, original submission:  

The callers already ensure the ipaddr/netmask/gw won't be NULL, so remove the duplicated NULL checking in these static functions.
While at it, also move the code saving old_address for netmask/gw as it's only used when address is actually being changed.

Axel Lin <axellin>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by axellin (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-01-09 dziegel StatusNone Done
        Open/ClosedOpen Closed
    2018-01-09 axellin Attached File- Added 0001-netif-Remove-unnecessary-NULL-checking-in-netif_do_s.patch, #42873

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code