patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9578, lowpan6: Rework to speed up...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9578: lowpan6: Rework to speed up dequeue datagram process

Submitted by:  Axel Lin <axellin>
Submitted on:  Sat 03 Mar 2018 03:52:00 PM UTC  
 
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Planned Release:  None

Tue 13 Mar 2018 12:20:08 AM UTC, comment #4: 

pushed, thanks for the review.

Axel Lin <axellin>
Project Member
Mon 12 Mar 2018 03:34:34 PM UTC, comment #3: 

Looks good, can you push it?

Simon Goldschmidt <goldsimon>
Project Administrator
Sun 11 Mar 2018 03:38:59 AM UTC, comment #2: 

v2: Rebase to current git tree for testing.

(file #43511)

Axel Lin <axellin>
Project Member
Sat 03 Mar 2018 09:07:47 PM UTC, comment #1: 

I'm working on 6LoWPAN at the moment. I'm doing this rather theoretical, too, via the new zepif, but wireshark helps me and I'm integrating parts of contiki as my virtual counterpart for compatibility tests.

Being like that, I'll pick this up in some days or weeks, hopefully :-)

We need to change reassembly anyway to not depend on receiving fragments in the correct order...

Simon Goldschmidt <goldsimon>
Project Administrator
Sat 03 Mar 2018 03:52:00 PM UTC, original submission:  

Current implementation iterates the lowpan6_data.reass_list every time dequeue_datagram() is called.
We can get previous lrh in all the context calling dequeue_datagram().
By adding a prev arguemnt to dequeue_datagram(), we can speed up the dequeue datagram process.

All the callers never check return value of dequeue_datagram() as it always return ERR_OR, thus make it return void instead.

PS.
I cannot test this patch so post it here for review.
Appreciate if someone can test it.

Axel Lin <axellin>
Project Member

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by axellin (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-03-13 axellin Open/ClosedOpen => Closed
    2018-03-11 axellin Attached File- => Added 0001-lowpan6-Rework-to-speed-up-dequeue-datagram-process-v2.patch, #43511
    2018-03-03 axellin Attached File- => Added 0001-lowpan6-Rework-to-speed-up-dequeue-datagram-process.patch, #43445

    Back to the top


    Powered by Savane 3.5