patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9611, tftp client


You are not allowed to post comments on this tracker with your current authentication level.

patch #9611: tftp client

Submitted by:  Ben <bwijen>
Submitted on:  Sat 31 Mar 2018 09:03:18 AM UTC  
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Planned Release:  None

( Jump to the original submission)

Mon 08 Oct 2018 10:51:46 AM UTC, comment #10: 

Applied, thanks for your contribution!

Dirk Ziegelmeier <dziegel>
Project Administrator
Tue 03 Jul 2018 06:17:54 AM UTC, comment #9: 

Hi Simon,

Sorry for the delay.
The 0004-patch is a squashed version of 0001 and 0002 with some files renamed, as you suggested. (Still based on the 2.0.3 branch.)
If you want, I can rebase on master.

Please note, that the tftp-client functionality works (at least for me)

If you require something more, please let me know, although my time is scarce I'm willing to take this to the end.


Ben <bwijen>
Mon 02 Jul 2018 07:43:52 PM UTC, comment #8: 

I'll have to add that the patch doesn't apply and that's why I ask.

If there's no reaction, I think I'll close this.

Simon Goldschmidt <goldsimon>
Project Administrator
Thu 28 Jun 2018 08:14:08 PM UTC, comment #7: 


Simon Goldschmidt <goldsimon>
Project Administrator
Wed 13 Jun 2018 01:14:30 PM UTC, comment #6: 

Sorry for the delay. Could you describe what's in your patch, please? Is it a fully working tftp client? Or just yet another example like the last patch?

Simon Goldschmidt <goldsimon>
Project Administrator
Fri 27 Apr 2018 11:53:55 AM UTC, comment #5: 

Sorry for the delay.
Please see the 0004 path.

Do you require more than squashing and renaming?
If so, let me know.

(file #44044)

Ben <bwijen>
Wed 25 Apr 2018 06:40:56 PM UTC, comment #4: 

Since this patch does not contain things worth to keep (up to now), can I close it or do you have more input/progress to share?

Simon Goldschmidt <goldsimon>
Project Administrator
Fri 06 Apr 2018 07:42:08 PM UTC, comment #3: 

Renaming the file after adding a tftp client is fine. However, having one 'init' function for both client and server is a not good idea. I can clean that up once your client patches are acceptable though.

Simon Goldschmidt <goldsimon>
Project Administrator
Fri 06 Apr 2018 12:10:01 PM UTC, comment #2: 

Hi Simon,

Thanks for your reply.
Regarding your comments:

  • I have created bug #53574: "DHCP issue when LWIP_DHCP_BOOTP_FILE is set"
  • I will make sure to squash any future patches...

Regarding the split:
The tftp code is over 90% both server and client.
Would you agree renaming 'tftp_server' to just 'tftp'?
tftp_init would then mean both client and server.

Or would you prefer the more drastic approach: renaming the current implementation tftp and added tftp_client and tftp_server wrappers?

Thank you,


Ben <bwijen>
Tue 03 Apr 2018 07:46:56 PM UTC, comment #1: 

Yes, having a TFTP client integrated with the server would be welcome. But please:
- rename or add files to reflect their contents (server vs. client)
- name functions to reflect their usage (server vs. client; tftp_init() is a really bad example here)
- keep one patch for one issue (tftp client) and don't mix it with a bugfix (dhcp issue) - I've change the summary for this.

On the DHCP issue, you're probably right. However, after your change, it seems like with "parse_sname_as_options != 0", the file name could be copied multiple times?

Simon Goldschmidt <goldsimon>
Project Administrator
Sat 31 Mar 2018 09:03:18 AM UTC, original submission:  


I'm working on an tftp client implementation.
I added two patches for a first review.
Please let me know if this is something you are interested in.

While using my implementation, I think I also found
a bug in the DHCP implementation (when LWIP_DHCP_BOOTP_FILE is set)
Could you please confirm?

The patches are on top of the STABLE-2.0.3_RELEASE tag.

Thank you,


Ben <bwijen>


Attached Files
file #44563:  0005-tftp-Add-client-functionality.patch added by bwijen (15KiB - text/x-patch - rebased on STABLE-2_1_0_RC1)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by bwijen (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.




    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-10-08 dziegel StatusNone => Done
        Open/ClosedOpen => Closed
    2018-07-16 bwijen Attached File- => Added 0005-tftp-Add-client-functionality.patch, #44563
    2018-04-27 bwijen Attached File- => Added 0004-tftp-Add-client-functionality.patch, #44044
    2018-04-03 goldsimon Summarytftp client/dhcp issue => tftp client
    2018-03-31 bwijen Attached File- => Added 0001-tftp-Add-helper-functions.patch, #43738
        Attached File- => Added 0003-dhcp-Fix-BOOTP_FILE-bug.patch, #43739
        Attached File- => Added 0002-tftp-Add-client-functionality.patch, #43740

    Back to the top

    Powered by Savane 3.5