patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9665, Introduce lwip_toupper and use it...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9665: Introduce lwip_toupper and use it in netbiosns.c

Submitter:  Axel Lin <axellin>
Submitted:  Wed 27 Jun 2018 07:17:49 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Planned Release:  None

Wed 27 Jun 2018 03:19:18 PM UTC, comment #2: 

Applied to commit 4027a2ae58db, thanks for the review.

Axel Lin <axellin>
Group Member
Wed 27 Jun 2018 03:01:23 PM UTC, comment #1: 

Looks good. Please push.

Simon Goldschmidt <goldsimon>
Group administrator
Wed 27 Jun 2018 07:17:49 AM UTC, original submission:  

I got below build warning if #define LWIP_NO_CTYPE_H 1.
So I'm wondering if it is required to introduce lwip_toupper
and implement it when LWIP_NO_CTYPE_H=1.

cc -g -DLWIP_DEBUG -Wall -pedantic -Werror -Wparentheses -Wsequence-point -Wswitch-default -Wextra -Wundef -Wshadow -Wpointer-arith -Wcast-qual -Wc++-compat -Wwrite-strings -Wold-style-definition -Wcast-align -Wmissing-prototypes -Wredundant-decls -Wnested-externs -Wunreachable-code -Wuninitialized -Wmissing-prototypes -Wredundant-decls -Waggregate-return -Wlogical-not-parentheses -Wlogical-op -Wc90-c99-compat -Wtrampolines -I. -I../../.. -I../../../../lwip/src/include -I../../../ports/unix/port/include -I../../../../mbedtls/include -Wno-redundant-decls -DLWIP_HAVE_MBEDTLS=1 -Wno-c90-c99-compat -c ../../../../lwip/src/apps/netbiosns/netbiosns.c
../../../../lwip/src/apps/netbiosns/netbiosns.c: In function ‘netbiosns_set_name’:
../../../../lwip/src/apps/netbiosns/netbiosns.c:502:37: error: implicit declaration of function ‘toupper’ [-Werror=implicit-function-declaration]
     netbiosns_local_name[i] = (char)toupper((unsigned char)hostname[i]);
                                     ^~~~~~~
cc1: all warnings being treated as errors
/home/axel/git/lwip/lwip-contrib/ports/unix/../Common.allports.mk:91: recipe for target 'netbiosns.o' failed
make: * [netbiosns.o] Error 1

Axel Lin <axellin>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by axellin (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-06-27 axellin Open/ClosedOpen Closed
    2018-06-27 axellin Attached File- Added 0001-Introduce-lwip_toupper-and-use-it-in-netbiosns.c.patch, #44443

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code