patchlwIP - A Lightweight TCP/IP stack - Patches: patch #10412, freertos port: xSemaphoreTake()...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #10412: freertos port: xSemaphoreTake() should return pdFAIL

Submitter:  quanjia <quanjia>
Submitted:  Sat 18 Nov 2023 02:41:31 AM UTC
   
 
Category:  Contrib Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
Planned Release:  None

Sat 18 Nov 2023 02:41:31 AM UTC, original submission:  

in contrib\ports\freertos\sys_arch.c
sys_arch_sem_wait(sys_sem_t *sem, u32_t timeout_ms)
{
    ...
    ret = xSemaphoreTake(sem->sem, timeout_ticks);
    if (ret == errQUEUE_EMPTY) {
      /* timed out */
      return SYS_ARCH_TIMEOUT;
    }
    ...
}

call xSemaphoreTake() check return value with errQUEUE_EMPTY, but actually, xSemaphoreTake() returns only pdPASS/pdFAIL.
In fact errQUEUE_EMPTY is 0, pdFAIL is also 0, so that still works, but there may be some misleading, so I think it's better to fix it.

quanjia <quanjia>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by quanjia (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-11-18 quanjia Attached File- Added 0001-freertos-port-xSemaphoreTake-should-return-pdFAIL-on.patch, #55337

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code