lwIP - A Lightweight TCP/IP stack - Patches: patch #9579, unit: increase test timeout
You are not allowed to post comments on this tracker with your current authentication level.
patch #9579: unit: increase test timeout
Submitter: | Joel Cunningham <jcunningham> | ||
Submitted: | Sat 03 Mar 2018 11:15:40 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Wont Do | Privacy: | Public |
Assigned to: | jcunningham | Open/Closed: | Closed |
Planned Release: | None |
Sun 04 Mar 2018 04:52:20 PM UTC, comment #5: |
Joel Cunningham <jcunningham> |
Sun 04 Mar 2018 09:53:56 AM UTC, comment #4: Check has a timeout? I wasn't even aware of that :-) And I don't know why it is set to 4 seconds. Enabling the xml output is a good idea. |
Simon Goldschmidt <goldsimon> |
Sun 04 Mar 2018 08:01:27 AM UTC, comment #3: OK for me |
Dirk Ziegelmeier <dziegel> |
Sun 04 Mar 2018 07:47:46 AM UTC, comment #2: If anyone is interested, I figured out that check can write out the duration of each test to an xml file. On my MacBook Air (core 2 duo from 2012) the switch to memcpy reduced the duration from 2.335124s to 0.004089s, on my win10 box (core 2 duo from 2009) it is even slower.
|
Joel Cunningham <jcunningham> |
Sat 03 Mar 2018 11:49:18 PM UTC, comment #1: Actually, I was able to speed up the unit tests by replacing the byte-by-byte compare loops with memcmp. Now the unit tests are completing within the 4 second default. See b1258bf8e64d1bd71bbcbd33af0e5da2262e5a78 |
Joel Cunningham <jcunningham> |
Sat 03 Mar 2018 11:15:40 PM UTC, original submission:
Any objections to increasing the unit test timeout?
|
Joel Cunningham <jcunningham> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-03-03 | jcunningham | Status | None | Wont Do | |
Open/Closed | Open | Closed | |||
2018-03-03 | jcunningham | Attached File | - | Added 0001-unit-increase-test-timeout.patch, #43446 |
Powered by Savane 3.13-bb6a.
Corresponding source code
XML output enabled in b28e9797394beda8dcf35f1fd9cb3f0bcbda5f91
And yes, by default check uses a 4 second timeout per test. I found more info about it here: https://libcheck.github.io/check/doc/check_html/check_4.html#Test-Timeouts