helpdavfs2 - Support: sr #108104, davfs2 fix DESTDIR support

 
 

sr #108104: davfs2 fix DESTDIR support

Submitted by:  Jeremy Olexa <jolexa>
Submitted on:  Wed 08 Aug 2012 06:27:20 PM UTC  
 
Category: NonePriority: 5 - Normal
Severity: 3 - NormalStatus: Done
Privacy: PublicAssigned to: Werner Baumann <wbaumann>
Open/Closed: OpenOperating System: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 20 Aug 2012 07:10:39 PM UTC, comment #3:

After taking some more time to think about it and after remembering the syntax of the ln command I can't help but recognizing that you are right.

I fixed it in CVS (MAIN branch and the rel-1-4-6 branch).

Thanks for insisting
Werner

Werner Baumann <wbaumann>
Project AdministratorIn charge of this item.
Mon 20 Aug 2012 01:12:29 PM UTC, comment #2:

Hello, Thanks for the follow up, Werner.

You can consider the next step after "make DESTDIR=/foo install" to be "cp DESTDIR /" if you have the proper access (root). With that in mind, you can see that the symlinks are wrong which is what this patch fixes.

Anyway, it isn't distro specific but rather a general bug. I found two other distros that "fix" symlinks in my cursory search.

https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/davfs2

http://pkgs.fedoraproject.org/cgit/davfs2.git/commit/?id=08508757de456429b5519bb8481aefcbdcb74288

I hope that you reconsider this bug, thanks.

Jeremy Olexa <jolexa>
Sun 19 Aug 2012 08:00:32 PM UTC, comment #1:

I must confess that I'm confused about these Gentoo bug reports.

As far as I understand DESTDIR is used to build a package within DESTDIR and without the need of root priveleges. The build process must only create files in DESTDIR and not touch any system files, links or directories. In short: the build process must treat DESTDIR as root of the file system, without exception.

of course there will be a problem with testing because the system's mount command does not know about DESTDIR. I don't know a way around these problems (maybe chroot for testing?).

But changing the build process as you propose would probably earn me a lot of bug reports from other distributions.

Cheers
Werner

Werner Baumann <wbaumann>
Project AdministratorIn charge of this item.
Wed 08 Aug 2012 06:27:20 PM UTC, original submission:

Hello,

Please see downstream bug report: https://bugs.gentoo.org/384703

Patch located on the bug or here: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-fs/davfs2/files/davfs2-1.4.7-destdir.patch?revision=1.1&view=markup

Jeremy Olexa <jolexa>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by wbaumann (Posted a comment)
  • -unavailable- added by jolexa (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 20 Aug 2012 07:10:39 PM UTCwbaumannStatusWont Do=>Done
    Sun 19 Aug 2012 08:00:32 PM UTCwbaumannStatusNone=>Wont Do
      Assigned toNone=>wbaumann

    Back to the top


    Powered by Savane 3.1-cleanup