tasklwIP - A Lightweight TCP/IP stack - Tasks: task #10173, Add IPCOPY and HWACOPY

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #10173: Add IPCOPY and HWACOPY

Submitter:  Bill Auerbach <billauerbach>
Submitted:  Mon 15 Feb 2010 01:46:39 PM UTC
   
 
Category:  None Should Start On:  Mon 15 Feb 2010 05:00:00 AM UTC
Should be Finished on:  Mon 15 Feb 2010 05:00:00 AM UTC Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Percent Complete:  100%
Open/Closed:  Closed Planned Release:  1.4.0
Effort:  0.00

Thu 29 Apr 2010 04:58:09 AM UTC, comment #5: 

No need for that, thanks. I've done it already.

Simon Goldschmidt <goldsimon>
Group administrator
Wed 28 Apr 2010 07:52:01 PM UTC, comment #4: 

I'll do it if you want me to.  If you've done the first part, I'll fix the for loops.  I can actually do the whole patch for this against CVS head if you want. I have never gotten to a project build where I can go between STABLE and HEAD because of compatibility issues so I am reluctant to submit a patch I can't build (easily) and run in a real product.

Bill Auerbach <billauerbach>
Wed 28 Apr 2010 07:43:33 PM UTC, comment #3: 

Hmm, it would have been easier if there's a patch, but I'll try to do it without one ;-)

Simon Goldschmidt <goldsimon>
Group administrator
Wed 21 Apr 2010 09:43:09 PM UTC, comment #2: 

Can we please fold into this task changing the few cases where a for loop is used to do a byte copy of the HWA/MAC_ADDR into a MACADDR_COPY?  I didn't add that initially since I had already changed them locally to SMEMCPYs but when using the CVS head I see the loops and am reminded of the for loops.

Bill Auerbach <billauerbach>
Mon 22 Feb 2010 01:58:11 PM UTC, comment #1: 

The idea is fine, not so sure about the names.  How about IPADDR_COPY and MACADDR_COPY?


Kieran Mansley <kieranm>
Group Member
Mon 15 Feb 2010 01:46:39 PM UTC, original submission:  

I would like to see IPCOPY defined and used for all IP address copies (instead of SMEMCPY) and HWACOPY for MAC address copies.

In most cases an IP address can simply be assigned with the u32_t load/store.  On an 8-bit processor with 32-bit load/stores the overhead of memcpy is huge compared to what it could be.

Same for HWACOPY.  In fact I think the HWA type should be a typedef overridden in CC.h.  If it's a union with 3 u16_t or 1 u32_t and 1 u16_t, HWACOPY can do the copy in 2 or 3 load/store instructions instead of memcpy.

IP addresses and MAC addresses are copied on every packet sent.  The benefit here is significant.

Bill Auerbach <billauerbach>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Updated the item)
  • -email is unavailable- added by kieranm (Posted a comment)
  • -email is unavailable- added by billauerbach (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-04-29 goldsimon StatusNone Done
        Percent Complete0% 100%
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2010-04-21 goldsimon Planned ReleaseNone 1.4.0

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code