tasklwIP - A Lightweight TCP/IP stack - Tasks: task #13729, Convert netif addresses (IPv4...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #13729: Convert netif addresses (IPv4 & IPv6) to ip_addr_t

Submitter:  Simon Goldschmidt <goldsimon>
Submitted:  Mon 31 Aug 2015 06:34:54 PM UTC
   
 
Category:  None Should Start On:  Mon 31 Aug 2015 12:00:00 AM UTC
Should be Finished on:  Mon 31 Aug 2015 12:00:00 AM UTC Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  goldsimon Percent Complete:  100%
Open/Closed:  Closed Planned Release:  1.5.0
Effort:  0.00

Fri 05 Aug 2016 05:57:49 PM UTC, comment #5: 


> why this was even necessary?


Because it shall be possible to pass the addresses to API functions taking generic "ip_addr_t" (pointer) arguments.

That should answer all the other questions, I think?

Simon Goldschmidt <goldsimon>
Group administrator
Fri 05 Aug 2016 04:44:26 PM UTC, comment #4: 

I know I'm a bit late, but why this was even necessary?  Why pretend that an IPv6 address of the interface may be anything but an IPv6 address and use generic ip_addr_t for only to use ip_2_ip6 macro practically every time you need to use it?

The same goes for IPv4 address/mask.

Note that the functions declared in netif.h specific to IPv4 or IPv6 still use ip4_addr_t or ip6_addr_t arguments respectively.

So why all the contortions?

Valery Ushakov <uwe>
Thu 24 Sep 2015 06:07:24 AM UTC, comment #3: 

Right. Sorry for not applying your patch, i just saw it now.

Simon Goldschmidt <goldsimon>
Group administrator
Wed 23 Sep 2015 09:21:31 PM UTC, comment #2: 

Loopif (for IPv6) needs a little love after db76671d4d6b0af519fe4af465bae897f24291c0 and doesn't build.

It needs to use IP_ADDR6 since the netif IP address type change.  Patch makes this change.

(file #34967)

Joel Cunningham <jcunningham>
Group Member
Wed 23 Sep 2015 08:10:33 PM UTC, comment #1: 

Done. Hopefully this doesn't break too many ports.

Simon Goldschmidt <goldsimon>
Group administrator
Mon 31 Aug 2015 06:34:54 PM UTC, original submission:  


Simon Goldschmidt <goldsimon>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by uwe (Posted a comment)
  • -email is unavailable- added by jcunningham (Updated the item)
  • -email is unavailable- added by goldsimon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-09-23 jcunningham Attached File- Added 0001-task-13729-Convert-loopif-to-use-IP_ADDR6-for-IPv6.patch, #34967
    2015-09-23 goldsimon Percent Complete0% 100%
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2015-09-01 goldsimon SummaryConvert netif addresses (IPv4 &amp; IPv6) to ip_addr_T Convert netif addresses (IPv4 & IPv6) to ip_addr_t

    Back to the top

    Powered by Savane 3.15-e6e5.
    Corresponding source code