tasklwIP - A Lightweight TCP/IP stack - Tasks: task #13907, PPP cleanups

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #13907: PPP cleanups

Submitter:  Dirk Ziegelmeier <dziegel>
Submitted:  Mon 29 Feb 2016 08:35:16 AM UTC
   
 
Category:  PPP Should Start On:  Mon 29 Feb 2016 12:00:00 AM UTC
Should be Finished on:  Mon 29 Feb 2016 12:00:00 AM UTC Priority:  6
Status:  Done Privacy:  Public
Assigned to:  None Percent Complete:  100%
Open/Closed:  Closed Planned Release:  1.5.0
Effort:  0.00

Sat 23 Apr 2016 08:31:46 AM UTC, comment #4: 

Another idea: Move all headers that are of no interest to a PPP user ("private headers") from include/netif/ppp to /netif/ppp.

Dirk Ziegelmeier <dziegel>
Group administrator
Thu 21 Apr 2016 09:14:50 PM UTC, comment #3: 

A project without PPP does not build anymore:

lwip-contrib/ports/unix/proj/minimal$ make
gcc -g -Wall -DLWIP_UNIX_LINUX -DLWIP_DEBUG -pedantic -Werror -Wparentheses -Wsequence-point -Wswitch-default -Wextra -Wundef -Wshadow -Wpointer-arith -Wcast-qual -Wc++-compat -Wwrite-strings -Wold-style-definition -Wcast-align -Wmissing-prototypes -Wredundant-decls -Wnested-externs -Wno-address -Wunreachable-code -Wuninitialized -Wlogical-op -I. -I../../../.. -I../../../../../lwip/src/include -I../../../../ports/unix/include -c ../../../../../lwip/src/core/init.c
In file included from ../../../../../lwip/src/include/lwip/memp.h:42:0,
                 from ../../../../../lwip/src/include/lwip/stats.h:38,
                 from ../../../../../lwip/src/core/init.c:42:
../../../../../lwip/src/include/lwip/priv/memp_std.h:97:5: error: "PPP_SUPPORT" is not defined [-Werror=undef]
 #if PPP_SUPPORT
     ^
In file included from ../../../../../lwip/src/include/lwip/memp.h:47:0,
                 from ../../../../../lwip/src/include/lwip/stats.h:38,
                 from ../../../../../lwip/src/core/init.c:42:
../../../../../lwip/src/include/lwip/priv/memp_std.h:97:5: error: "PPP_SUPPORT" is not defined [-Werror=undef]
 #if PPP_SUPPORT
     ^
cc1: all warnings being treated as errors
../Common.mk:84: recipe for target 'init.o' failed
make: * [init.o] Error 1

Sylvain Rochet <gradator>
Group Member
Thu 21 Apr 2016 08:30:44 PM UTC, comment #2: 

Options moved to ppp_opts.h

Dirk Ziegelmeier <dziegel>
Group administrator
Tue 08 Mar 2016 08:09:26 AM UTC, comment #1: 


> Move most options into a new netif/ppp/ppp_opts.h


That would be a good idea.

> Move mempools out of memp_std.h into PPP code to create private mempools


I don't really care.

> Let the user call ppp_init()


I'd rather keep it in lwip_init().


Sylvain, any comments on this?

Simon Goldschmidt <goldsimon>
Group administrator
Mon 29 Feb 2016 08:35:16 AM UTC, original submission:  

- Move most options into a new netif/ppp/ppp_opts.h file to unclutter opt.h some more
   
- Move mempools out of memp_std.h into PPP code to create private mempools and decouple core pools from PPP
   
- Let the user call ppp_init() (breaking change). Maybe we can move PPP specific code out of init.c - but we'll have to figure something out for the #warning checks before that.

This will make the core code more independent from PPP code.

Dirk Ziegelmeier <dziegel>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gradator (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by dziegel (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-04-25 dziegel StatusNone Done
        Percent Complete30% 100%
        Open/ClosedOpen Closed
    2016-04-21 dziegel Percent Complete0% 30%
    2016-03-08 goldsimon Priority5 - Normal 6

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code