tasklwIP - A Lightweight TCP/IP stack - Tasks: task #14798, PPP: improve PPP_DEBUG macro...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #14798: PPP: improve PPP_DEBUG macro support

Submitted by:  Marco <marcoe>
Submitted on:  Thu 04 Jan 2018 03:27:27 PM UTC  
 
Category:  PPP Should Start On:  Thu 04 Jan 2018 12:00:00 AM UTC
Should be Finished on:  Thu 04 Jan 2018 12:00:00 AM UTC Priority:  3 - Low
Status:  Done Privacy:  Public
Percent Complete:  100% Assigned to:  Simon Goldschmidt <goldsimon>
Open/Closed:  Closed Planned Release:  None
Effort:  1.00

( Jump to the original submission)

Tue 28 Jan 2020 01:32:44 PM UTC, comment #10: 

I knew I was too late, it was a joke :-)  Time is a harsh resource since I founded my company, hopefully it will get better over time.

Sylvain Rochet <gradator>
Project Member
Mon 27 Jan 2020 07:29:23 PM UTC, comment #9: 

Yes, too late, I accidentally pushed it with other commits and after that figured it was probably ok to leave it until you object :-)

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 23 Jan 2020 01:26:43 PM UTC, comment #8: 

Woops, sorry for the delay. Sure, this is perfectly fine, go ahead :-)  (Or am I too late ? ;-)

Sylvain Rochet <gradator>
Project Member
Fri 10 Jan 2020 10:19:36 PM UTC, comment #7: 

Pushed after lack of response... ;-) Sylvain: feel free to revert if it doesn' fit

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 10 Jan 2020 10:18:21 PM UTC, comment #6: 

Pushed after lack of response... ;-) Sylvain: feel free to revert if it doesn' fit

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Mon 23 Dec 2019 08:08:04 PM UTC, comment #5: 

I've attached a suggestion that ensures the output code is only compiled in if enabled.

Since that requires changing all callers to call e.g. 'ppp_info(("msg"))' instead of 'ppp_info("msg")': Sylvain, are you ok with this?

(file #48113)

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 05 Jan 2018 10:30:11 AM UTC, comment #4: 

Ok, the summary could become "PPP: improve PPP_DEBUG macro support (now it doesn't suppress all PPP debug messages)".

Marco <marcoe>
Thu 04 Jan 2018 04:46:52 PM UTC, comment #3: 

Ok, a task is fine then. But it needs a summary that tells us what to do when viewing the task list.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 04 Jan 2018 04:44:05 PM UTC, comment #2: 

I was thinking it could be an enhancement and, as a consequence, that a task was needed to proceed with a little cleanup of this part of code. Sorry if this is not the intended meaning for "task". I don't think this is a bug because as far as I know PPP is fully working, also if not size-optimized. If you prefer to have a bug report instead I will close here and open a bug report, tell me how to proceed.

In any case, I'm using lwIP 2.0.3 release version (92f23d6ca0971a32f2085b9480e738d34174417b).

Marco <marcoe>
Thu 04 Jan 2018 04:15:36 PM UTC, comment #1: 

If this should be a task, you should have given it a summary that tells us what to do. "PPP log messages" is not a task. Do you think it's a bug that 28th PPP debug disabled, too many things are linked in? If so, a bug report would have been better.

Which version of lwip are you talking about anyway?

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 04 Jan 2018 03:27:27 PM UTC, original submission:  

Hello all,
I've noticed that also with PPP_DEBUG = 0 some kiloBytes of flash memory are occupied by ppp_vslprintf() code and by many PPP debug strings.

In fact, debugging messages are not consistent across PPP code because:
- in some points log messages are correctly produced using macros like LCPDEBUG(a) defined in pppdebug.h
- in other points there are direct calls to ppp_warn(), ppp_notice(), ...
- in other points the calls to ppp_warn(), ppp_notice(), ... are inside a #if PPP_DEBUG ... #endif block

I think it would be nice to have the possibility to completely remove these log messages and related helper functions in a production environment as well as we can do it for all the other debug messages inside lwIP.

Bye

Marco <marcoe>

 

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gradator (Posted a comment)
  • -email is unavailable- added by goldsimon
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by marcoe (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-01-10 goldsimon StatusNone => Done
        Percent Complete0% => 100%
        Assigned toNone => goldsimon
        Open/ClosedOpen => Closed
    2019-12-23 goldsimon Attached File- => Added 0001-ppp-improve-PPP_DEBUG-macro-support.patch, #48113
        Carbon-Copy- => Added sylvain rochet <gradator@gradator.net>
    2018-01-05 goldsimon SummaryPPP log messages => PPP: improve PPP_DEBUG macro support

    Back to the top


    Powered by Savane 3.5