lwIP - A Lightweight TCP/IP stack - Tasks: task #6597, Cleaner source code regulations...
You are not allowed to post comments on this tracker with your current authentication level.
task #6597: Cleaner source code regulations are needed
Submitter: | Simon Goldschmidt <goldsimon> | ||
Submitted: | Thu 08 Mar 2007 11:39:30 AM UTC | ||
Category: | None | Should Start On: | Thu 08 Mar 2007 12:00:00 AM UTC |
Should be Finished on: | Thu 08 Mar 2007 12:00:00 AM UTC | Priority: | 1 - Later |
Status: | Done | Privacy: | Public |
Assigned to: | None | Percent Complete: | 80% |
Open/Closed: | Closed | Planned Release: | None |
Effort: | 0.00 |
Jump to the original submission
Mon 18 Jun 2007 07:58:56 PM UTC, comment #12: |
Simon Goldschmidt <goldsimon> |
Fri 08 Jun 2007 02:30:50 PM UTC, comment #11: I think the code is pretty good formatted by now...
|
Simon Goldschmidt <goldsimon> |
Thu 12 Apr 2007 01:02:06 AM UTC, comment #10: Ok, I understand, I will try to separte them...
|
Frédéric Bernon <fbernon> |
Thu 12 Apr 2007 12:54:13 AM UTC, comment #9:
|
Jonathan Larmour <jifl> |
Thu 12 Apr 2007 12:41:24 AM UTC, comment #8:
|
Frédéric Bernon <fbernon> |
Wed 11 Apr 2007 11:28:10 PM UTC, comment #7: Some other projects I am involved in are quite insistent you commit whitespace and indent changes in separate cvs commits all by themselves. Otherwise when you diff specific CVS revisions, you can't easily see what is just a whitespace change, and what is a commit that actually changes code.
|
Jonathan Larmour <jifl> |
Thu 22 Mar 2007 06:41:08 PM UTC, comment #6: Just for your information, I have reindent some part of code (api_msg, api_lib...) during last patchs, but there is lot of job again...
|
Frédéric Bernon <fbernon> |
Mon 12 Mar 2007 08:53:44 AM UTC, comment #5: Hmm, someone else mentioned something about CVS converting automatically. I'm not sure about that. Try to check in Unix linebreaks if possible. |
Kieran Mansley <kieranm> |
Sun 11 Mar 2007 05:26:14 PM UTC, comment #4: It's a CRLF line termination in most of files, but I don't know if it's Windows or Unix style...
|
Frédéric Bernon <fbernon> |
Sun 11 Mar 2007 05:05:42 PM UTC, comment #3: Either a comment on line termination characters is missing contrib.txt (or some other file) or I don't find it. What ar we using, Windows or Unix linebreaks?
|
Simon Goldschmidt <goldsimon> |
Fri 09 Mar 2007 09:45:37 AM UTC, comment #2: I always afraid to let a software change a source code automaticlly. But if you're sure about it...
|
Frédéric Bernon <fbernon> |
Thu 08 Mar 2007 11:42:37 AM UTC, comment #1: I've not used indent before, so can't comment on whether it is a suitable tool or the args you suggest, but a clean up of the indentation and code style would be welcome. |
Kieran Mansley <kieranm> |
Thu 08 Mar 2007 11:39:30 AM UTC, original submission:
Hi all,
|
Simon Goldschmidt <goldsimon> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-06-18 | goldsimon | Status | None | Done | |
Open/Closed | Open | Closed | |||
2007-06-08 | goldsimon | Percent Complete | 50% | 80% | |
2007-05-17 | goldsimon | Percent Complete | 0% | 50% |
Powered by Savane 3.13-d3ae.
Corresponding source code
I'll close this now as we have a clear explanation of how it should be (doc/contrib.txt) and except for ppp, everything seems fine to me!