lwIP - A Lightweight TCP/IP stack - Tasks: task #7136, Centralize mempool settings in...
You are not allowed to post comments on this tracker with your current authentication level.
task #7136: Centralize mempool settings in separate file
Submitter: | Jared Grubb <jgrubb> | ||
Submitted: | Wed 01 Aug 2007 12:26:33 AM UTC | ||
Category: | None | Should Start On: | Tue 31 Jul 2007 07:00:00 AM UTC |
Should be Finished on: | Tue 31 Jul 2007 07:00:00 AM UTC | Priority: | 3 - Low |
Status: | Done | Privacy: | Public |
Assigned to: | jgrubb | Percent Complete: | 100% |
Open/Closed: | Closed | Planned Release: | 1.3.0 |
Effort: | 0.00 |
Jump to the original submission
Wed 29 Aug 2007 09:03:11 AM UTC, comment #23: |
Kieran Mansley <kieranm> |
Mon 20 Aug 2007 04:43:03 PM UTC, comment #22:
|
Jared Grubb <jgrubb> |
Mon 20 Aug 2007 03:47:51 PM UTC, comment #21: Isn't it a mistake in stats.c ?
|
Frédéric Bernon <fbernon> |
Fri 17 Aug 2007 06:27:58 PM UTC, comment #20: The changes have been commited to CVS. Let me know how the new changes are, and if all's good, we can close this! |
Jared Grubb <jgrubb> |
Wed 15 Aug 2007 03:53:52 PM UTC, comment #19:
|
Jared Grubb <jgrubb> |
Wed 15 Aug 2007 06:04:15 AM UTC, comment #18: I like the idea of auto-configurable and user-define additional pools, but I don't exactly understand why this has to be in a separate file instead of lwipopts.h!
|
Simon Goldschmidt <goldsimon> |
Tue 14 Aug 2007 05:48:54 PM UTC, comment #17: There hasn't been much comment on this feature in a while, so I will post the latest memp_std.h file, which checks a MEMP_USE_CUSTOM_POOLS flag to determine whether it should attempt to include lwippools.h (a custom user file).
|
Jared Grubb <jgrubb> |
Fri 03 Aug 2007 04:11:52 PM UTC, comment #16:
|
Jared Grubb <jgrubb> |
Fri 03 Aug 2007 08:06:38 AM UTC, comment #15: Re: comment #13...
|
Kieran Mansley <kieranm> |
Thu 02 Aug 2007 07:03:15 PM UTC, comment #14: Attached are updated files:
|
Jared Grubb <jgrubb> |
Thu 02 Aug 2007 05:36:46 PM UTC, comment #13: I personally like seeing an explicit list of what the mempools are. But, you do bring up a valid argument: what happens if the user does minimal configuration. All the defaults should "just work" for the user. Also, if a new feature is added into CVS that requires a change to the lwippools.h, but the file is exclusively in the user's domain, then we have a maintanence issue.
If MEMP_USE_STD_POOLS==0 or MEMP_USE_CUSTOM_POOLS==1, then the lwippools.h file will be included.
|
Jared Grubb <jgrubb> |
Thu 02 Aug 2007 08:09:21 AM UTC, comment #12: Agreed about keeping all the user-tunable stuff in one place: I know the documentation that Jared is working on will help this a lot, but there is lots of confusion already among new users about how to configure the stack, so simple, easy, and in one place is better.
|
Kieran Mansley <kieranm> |
Thu 02 Aug 2007 05:42:14 AM UTC, comment #11:
|
Jonathan Larmour <jifl> |
Thu 02 Aug 2007 12:31:15 AM UTC, comment #10: Bugfix in memp.c version previously posted: need to change the MEMP_TYPE_SIZE macro! Yowzers that one hurt. |
Jared Grubb <jgrubb> |
Wed 01 Aug 2007 09:48:42 PM UTC, comment #9: As for aesthetics, perhaps:
|
Jared Grubb <jgrubb> |
Wed 01 Aug 2007 09:33:09 PM UTC, comment #8: Here are updates to the changes to the memp.def and memp.h files, and new changes for mem.c.
|
Jared Grubb <jgrubb> |
Wed 01 Aug 2007 03:43:52 PM UTC, comment #7:
|
Frédéric Bernon <fbernon> |
Wed 01 Aug 2007 02:42:15 PM UTC, comment #6:
|
Jonathan Larmour <jifl> |
Wed 01 Aug 2007 02:36:00 PM UTC, comment #5: I feel that like a nice solution (perhaps can be used for Simon's problem in https://savannah.nongnu.org/task/index.php?6863).
|
Frédéric Bernon <fbernon> |
Wed 01 Aug 2007 02:22:46 PM UTC, comment #4: Am I right in thinking that the main benefit of this is slightly smaller code?
|
Kieran Mansley <kieranm> |
Wed 01 Aug 2007 02:02:42 PM UTC, comment #3: Doh! I missed the stats.c patch that is there. In that case, if you haven't heard from anyone else in the next couple of days, I'd say just go ahead and check in. |
Jonathan Larmour <jifl> |
Wed 01 Aug 2007 02:01:39 PM UTC, comment #2: Seems like a good idead to me. However there needs to be something in stats.c as well to bring that in line.
|
Jonathan Larmour <jifl> |
Wed 01 Aug 2007 12:32:46 AM UTC, comment #1: Sorry, COPY-PASTE error. The fixed lines are (removed the + from the end of the first line shown here):
|
Jared Grubb <jgrubb> |
Wed 01 Aug 2007 12:26:33 AM UTC, original submission:
I would like to propose using the C preprocessor to generate the mempool pieces:
|
Jared Grubb <jgrubb> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 21 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-08-29 | kieranm | Status | Ready For Test | Done | |
Open/Closed | Open | Closed | |||
2007-08-17 | jgrubb | Status | None | Ready For Test | |
Percent Complete | 0% | 100% | |||
Assigned to | None | jgrubb | |||
Planned Release | None | 1.3.0 | |||
2007-08-14 | jgrubb | Attached File | - | Added memp_std.h, #13665 | |
Attached File | - | Added opt.h.patch, #13666 | |||
2007-08-02 | jgrubb | Attached File | - | Added memp.c, #13555 | |
Attached File | - | Added memp_std.h, #13556 | |||
Attached File | - | Added lwippools.h, #13557 | |||
Attached File | - | Added memp.h, #13558 | |||
2007-08-02 | jgrubb | Attached File | - | Added memp.c.patch, #13550 | |
2007-08-01 | jgrubb | Attached File | - | Added memp.def, #13543 | |
Attached File | - | Added mem.c.patch, #13544 | |||
Attached File | - | Added memp.h.patch, #13545 | |||
2007-08-01 | kieranm | Priority | 5 - Normal | 3 - Low | |
2007-08-01 | jgrubb | Attached File | - | Added memp.def, #13536 | |
Attached File | - | Added memp.h.patch, #13537 | |||
Attached File | - | Added memp.c.patch, #13538 | |||
Attached File | - | Added stats.c.patch, #13539 |
Powered by Savane 3.13-02a9.
Corresponding source code
Closing as no problems raised.