lwIP - A Lightweight TCP/IP stack - Tasks: task #7142, Sanity check user-configurable...
You are not allowed to post comments on this tracker with your current authentication level.
task #7142: Sanity check user-configurable values
Submitter: | Jonathan Larmour <jifl> | ||
Submitted: | Thu 02 Aug 2007 07:52:12 PM UTC | ||
Category: | None | Should Start On: | Wed 01 Aug 2007 11:00:00 PM UTC |
Should be Finished on: | Wed 01 Aug 2007 11:00:00 PM UTC | Priority: | 7 - High |
Status: | Done | Privacy: | Public |
Assigned to: | jifl | Percent Complete: | 100% |
Open/Closed: | Closed | Planned Release: | 1.3.0 |
Effort: | 0.00 |
Jump to the original submission
Fri 21 Sep 2007 02:58:47 PM UTC, comment #35: |
Simon Goldschmidt <goldsimon> |
Fri 21 Sep 2007 02:45:31 PM UTC, comment #34: I believe the values for these particular options should never be anything other than 0 or 1. |
Jonathan Larmour <jifl> |
Fri 21 Sep 2007 02:42:41 PM UTC, comment #33: Ok for me. Just a remark: if "options" are not 0 or 1 (I don't know, any strange use of expression where the value is >1), it can give a strange behavior... |
Frédéric Bernon <fbernon> |
Fri 21 Sep 2007 02:37:51 PM UTC, comment #32: I'm adding the attached patch too, to check there are sufficient timeouts. |
Jonathan Larmour <jifl> |
Wed 12 Sep 2007 01:17:18 PM UTC, comment #31: Looks right to me.
|
Jonathan Larmour <jifl> |
Wed 12 Sep 2007 09:41:16 AM UTC, comment #30: I would like to know if - with current code - it's wrong to suppose that slipif and ppp need NO_SYS=0? I ask this because I see they use sys_thread_new.
|
Frédéric Bernon <fbernon> |
Fri 07 Sep 2007 11:30:48 PM UTC, comment #29: Ok, since last changes are checking (and I hope, most of contrib modules updated), I close this task... |
Frédéric Bernon <fbernon> |
Fri 07 Sep 2007 08:52:57 PM UTC, comment #28: I'm happy with what you suggest in comment #21 if they are now obsolete.
|
Jonathan Larmour <jifl> |
Fri 07 Sep 2007 06:01:15 PM UTC, comment #27: Ok, it's check in. Any thoughts about comment #21, or can I close this task ?
|
Frédéric Bernon <fbernon> |
Fri 07 Sep 2007 01:48:03 PM UTC, comment #26: What you say is true. You can put them into the 'global' check section. |
Simon Goldschmidt <goldsimon> |
Wed 05 Sep 2007 12:57:54 PM UTC, comment #25: For ARP_TABLE_SIZE, it's not really references outside etharp.c (in fact, this is the index used to access to the table which are limited to s8_t range).
|
Frédéric Bernon <fbernon> |
Wed 05 Sep 2007 12:29:30 PM UTC, comment #24: (Simon wrote :)
|
Frédéric Bernon <fbernon> |
Wed 05 Sep 2007 11:04:00 AM UTC, comment #23: Seems fine to me. Go for it! |
Jonathan Larmour <jifl> |
Wed 05 Sep 2007 10:35:22 AM UTC, comment #22: If we want to centralize other sanity checkings, there also :
|
Frédéric Bernon <fbernon> |
Fri 31 Aug 2007 08:44:29 AM UTC, comment #21: There is also : MEMP_NUM_API_MSG, SYS_STATS, RAW_STATS, and some others removed from opt.h in https://savannah.nongnu.org/task/?7143.
|
Frédéric Bernon <fbernon> |
Fri 31 Aug 2007 08:29:52 AM UTC, comment #20: OK. |
Kieran Mansley <kieranm> |
Fri 31 Aug 2007 08:20:48 AM UTC, comment #19: There are :
|
Frédéric Bernon <fbernon> |
Fri 31 Aug 2007 08:16:14 AM UTC, comment #18: Can you briefly outline which are the deprecated options? |
Kieran Mansley <kieranm> |
Thu 30 Aug 2007 06:40:25 PM UTC, comment #17: ok for me |
Frédéric Bernon <fbernon> |
Thu 30 Aug 2007 06:25:09 PM UTC, comment #16: I see no reason not to. It seems like a good idea to me, especially with so much upheaval in 1.3. |
Jonathan Larmour <jifl> |
Thu 30 Aug 2007 06:12:12 PM UTC, comment #15:
|
Jared Grubb <jgrubb> |
Thu 30 Aug 2007 03:42:10 PM UTC, comment #14: I have made some more changes to this file to add some more checks and to move all the compile-time checks out of the LWIP_DEBUG ifdef block.
|
Jonathan Larmour <jifl> |
Thu 30 Aug 2007 03:11:01 PM UTC, comment #13: No, since if LWIP_DEBUG is undefined, you got :
|
Frédéric Bernon <fbernon> |
Thu 30 Aug 2007 02:52:23 PM UTC, comment #12: Looks good so far.
|
Jared Grubb <jgrubb> |
Thu 30 Aug 2007 10:20:55 AM UTC, comment #11: Ok, I have check in a first version for lwip_sanity_check, "as is".
|
Frédéric Bernon <fbernon> |
Thu 30 Aug 2007 10:03:29 AM UTC, comment #10: I don't see any reason to remove the "if (MEMP_NUM_TCP_SEG < TCP_SND_QUEUELEN)" check. If someone has configured it that way, it's definitely wrong. It doesn't matter that TCP_SND_QUEUELEN is for a single PCB in that sense. For multiple PCBs the problem would be worse not better!
|
Jonathan Larmour <jifl> |
Thu 30 Aug 2007 08:06:39 AM UTC, comment #9: It seems I misunderstand you for this one. I attach a new lwip_sanity_check function in a file.
|
Frédéric Bernon <fbernon> |
Wed 29 Aug 2007 11:26:56 PM UTC, comment #8: Thanks for this. Some comments on the patch:
|
Jonathan Larmour <jifl> |
Wed 29 Aug 2007 10:06:45 PM UTC, comment #7: I attach here a first patch file for these sanity check. Comments? |
Frédéric Bernon <fbernon> |
Wed 29 Aug 2007 09:22:49 AM UTC, comment #6: No, lwip_init is checked in, but not include - yet - this feature, but it can/should be the right place to add these sanity checkings, since some of them can only be done at runtime (the "warnings"). To give background, I copy/paste here the part of IRC chat where we talk about that with Jonathan:
|
Frédéric Bernon <fbernon> |
Wed 29 Aug 2007 09:02:13 AM UTC, comment #5: Given that the lwip_init function has gone in now, is this also fixed?
|
Kieran Mansley <kieranm> |
Wed 15 Aug 2007 10:04:58 PM UTC, comment #4: I have open a "task #7213 : Add a lwip_init function" where we have talk about the place where do these sanity check, since some of them (the "warnings") can only be done at runtime...
|
Frédéric Bernon <fbernon> |
Fri 03 Aug 2007 03:17:52 PM UTC, comment #3:
|
Jonathan Larmour <jifl> |
Fri 03 Aug 2007 08:03:32 AM UTC, comment #2: - Error if !UDP && DHCP
|
Frédéric Bernon <fbernon> |
Thu 02 Aug 2007 09:18:51 PM UTC, comment #1: Some more possibilites:
|
Jared Grubb <jgrubb> |
Thu 02 Aug 2007 07:52:12 PM UTC, original submission:
There should be more sanity checking of configuration settings in lwipopts.h, for example:
|
Jonathan Larmour <jifl> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 13 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-09-21 | jifl | Attached File | - | Added lwip.init.timeout.check.patch, #14004 | |
2007-09-07 | fbernon | Status | None | Done | |
Percent Complete | 90% | 100% | |||
Assigned to | None | jifl | |||
Open/Closed | Open | Closed | |||
2007-09-07 | fbernon | Percent Complete | 70% | 90% | |
2007-08-30 | jifl | Percent Complete | 30% | 70% | |
2007-08-30 | fbernon | Percent Complete | 20% | 30% | |
2007-08-30 | fbernon | Attached File | - | Added lwip_sanity_check.patch, #13837 | |
2007-08-29 | fbernon | Attached File | - | Added lwip_sanity_check.patch, #13833 | |
Percent Complete | 0% | 20% | |||
2007-08-29 | kieranm | Priority | 3 - Low | 7 - High | |
Planned Release | None | 1.3.0 |
Powered by Savane 3.13-02a9.
Corresponding source code
Wow, that's a strange #if...
I can live with a strange error report if people set those defines to anything other than 0 or 1 :-)