tasklwIP - A Lightweight TCP/IP stack - Tasks: task #7360, Move ethernet_input to etharp.c

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #7360: Move ethernet_input to etharp.c

Submitter:  Simon Goldschmidt <goldsimon>
Submitted:  Thu 04 Oct 2007 06:11:20 PM UTC
   
 
Category:  None Should Start On:  Thu 04 Oct 2007 12:00:00 AM UTC
Should be Finished on:  Thu 04 Oct 2007 12:00:00 AM UTC Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Percent Complete:  100%
Open/Closed:  Closed Planned Release:  None
Effort:  0.00

Fri 05 Oct 2007 03:17:03 PM UTC, comment #4: 

We could even remove etharp_ip_input and etharp_arp_input from etharp.h since they are(should) not directly call be other modules...

Frédéric Bernon <fbernon>
Group Member
Fri 05 Oct 2007 03:13:41 PM UTC, comment #3: 

I don't think there is a real port maintainer for unix port, but I'm agree to move it in "old" if noone want to take this role.

Else, I'm in flavor to rename "ethernet_input" in "etharp_input" to be coherent with other etharp functions, and since there is already "etharp_ip_input" and "etharp_arp_input".

Frédéric Bernon <fbernon>
Group Member
Fri 05 Oct 2007 02:03:35 PM UTC, comment #2: 

OK, done. I'll update the msvc port to use it. BTW: the unix port still calls etharp_arp_input directly, which is not thread-safe. Do we have a port maintainer for this or why is this in 'ports', not in 'old'?

Simon Goldschmidt <goldsimon>
Group administrator
Thu 04 Oct 2007 08:18:24 PM UTC, comment #1: 

ok for me

Frédéric Bernon <fbernon>
Group Member
Thu 04 Oct 2007 06:11:20 PM UTC, original submission:  

Anyone against moving the function ethernet_input() from tcpip.c into etharp.c? (The function splitting an incoming ethernet packet based on its protocol - IP/ARP/PPPOE)

It seems to fit best there since I also need it in the msvc6 port with NOSYS=1, and the current place in tcpip.c doesn't seem right with that configuration (since the whole code in tcpip.c is ifdef'ed with NO_SYS=0, and I normally don't build tcpip.c with NO_SYS=1).

Simon Goldschmidt <goldsimon>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by fbernon (Posted a comment)
  • -email is unavailable- added by goldsimon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-10-05 goldsimon StatusNone Done
        Percent Complete0% 100%
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code